-
-
Notifications
You must be signed in to change notification settings - Fork 423
fix(eventEmitter): improve event handling and listener management #2277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2277 +/- ##
==========================================
- Coverage 77.05% 76.81% -0.24%
==========================================
Files 84 89 +5
Lines 2157 2497 +340
Branches 555 648 +93
==========================================
+ Hits 1662 1918 +256
- Misses 382 463 +81
- Partials 113 116 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello and thanks for the PR!
Firstly, may I ask what's the motivation for the PR?
I'd say it can be merged, but for v6 - the change of behavior, while subtle, is a breaking change. Also the removal of removeListener is a breaking change - it should be added back.
Thank you :)
Hi, I noticed this behavior when experimenting with my own implementations in React. I think this behavior improves stability, even in the worst case. I think this change can be merged into version 6. Not urgent. |
Description
Types of changes
Refactored EventEmitter + add two new tests
Checklist