Skip to content

[WIP] 🌱 Change crt permissions in KCP to 0600 #12648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[WIP] 🌱 Change crt permissions in KCP to 0600 #12648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion util/secret/certificates.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ func (c *Certificate) AsFiles() []bootstrapv1.File {
out = append(out, bootstrapv1.File{
Path: c.CertFile,
Owner: rootOwnerValue,
Permissions: "0640",
Permissions: "0600",
Copy link
Member Author

@sbueringer sbueringer Aug 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context:

I wonder if 0600 leads to problems with: kubernetes/kubeadm#2473 (comment)

@neolit123 What do you think?

Is there a way that I can verify this works with userns? Do I only have to use Kubernetes >= 1.33?

Copy link
Member

@neolit123 neolit123 Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if i understand how userns works, this might be fine. you can test with any new release that has userns support. i don't think we ever tested kubeadm with userns yet, fwiw.

they are still fixing bugs and updating docs for the feature and we need it to be ga.

Copy link
Member

@neolit123 neolit123 Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, cis has been annoying since it doesn't consider permissions of the parent dir. distributions on top of kubeadm and capi ca choose to generate their own certs, but that's extra work.

Copy link
Member Author

@sbueringer sbueringer Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if "userns is being enabled by default in 1.33" (kubernetes/kubeadm#2473 (comment)) means that it's also used for static Pods per default

Copy link
Member

@neolit123 neolit123 Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's enabled in core k8s, but pod users must opt-in; kubeadm hasn't yet.

Copy link
Member Author

@sbueringer sbueringer Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thx!

Content: string(c.KeyPair.Cert),
})
}
Expand Down