Fix: Ensure .use() middleware works when path or prefix contains parameters #206
+47
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
.use()middleware being skipped whenprefixor.use()path contains parameters in@koa/routerv14 (see #202 ).Problem
@koa/routerintroduced a new optionpathAsRegExpin Layer, which defaults totruefor.use().pathAsRegExpis true,.use()paths are not processed withpath-to-regexp; instead, they are passed directly tonew RegExp()..use()path orprefixcontains parameters (e.g./:id,/:version), the generated regex fails, and the.use()middleware is skipped entirely.Minimal Reproduction
Example
Steps to Reproduce
Run the script directly:
Expected Behavior
Console should output:
Actual Behavior
Only the route handlers are triggered,
.use()middlewares are skipped:Changes
.use()registration:([^/]*)with an empty string"".pathAsRegExp.this.pathis a string instead of checking if it is falsy insetPrefixandLayer.constructor..use()middleware skipping issue.Compatibility
Checklist