Add firewall section to check-config.sh #13234
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13234 +/- ##
==========================================
- Coverage 21.87% 21.76% -0.12%
==========================================
Files 186 186
Lines 15202 15284 +82
==========================================
+ Hits 3325 3326 +1
- Misses 11438 11519 +81
Partials 439 439
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brandond
previously approved these changes
Nov 20, 2025
manuelbuil
previously approved these changes
Nov 21, 2025
mgfritch
requested changes
Nov 21, 2025
Signed-off-by: Derek Nola <[email protected]>
Member
Author
|
Updated PR with udp warnings and fixed firewalld checks 
|
mgfritch
approved these changes
Dec 2, 2025
| done | ||
|
|
||
| for port in $blocked_tcp_ports; do | ||
| wrap_bad " - Port $port is blocked" |
Contributor
There was a problem hiding this comment.
Suggested change
| wrap_bad " - Port $port is blocked" | |
| wrap_bad " - TCP Port $port is blocked" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Nola [email protected]
Proposed Changes
Anther take on #12847, placing firewall checks inside the check-config.sh script. Looks for ufw and firewalld. This approach should work better at balancing "does every user need this" with "people want an easy way to check" for firewall statuses.
Also fixed a random nit around how apparmor status was printing
Removed a 6 year old unused section of the check-config.sh
Types of Changes
Utility Script Improvements
Verification
./contrib/util/check-config.shon Ubuntu (with and without ufw rules) and on Rocky 9 (with and without firewalld rules)Testing
Linked Issues
User-Facing Change
Further Comments