Mysql reconnect option was broken

There were two problems discovered after the release of 72.0

 1. during config autoReconnect was firing in common cases and because
@connection_parameters was not yet set the adapter was broken.
 2. Processing of the reconnect: flag in db config would enable
reconnect whether it was set to true or false.

The other point is none of our tests ran into this because we do not
permute through all the possible config values.  Future work should
be to at least create a simple app from scratch as part of a CI
job so at least do not have failure out of the gate like this.

Author: enebo

lib/arjdbc/mysql/adapter.rb

@@ -72,16 +72,15 @@ def initialize(...)
         @config[:flags] ||= 0
 
         # assign arjdbc extra connection params
-        conn_params = build_connection_config(@config.compact)
+        @connection_parameters = @config.compact.deep_dup
+        build_connection_config(@connection_parameters)
 
         # JDBC mysql appears to use found rows by default: https://dev.mysql.com/doc/connector-j/en/connector-j-connp-props-connection.html
         # if @config[:flags].kind_of? Array
         #   @config[:flags].push "FOUND_ROWS"
         # else
         #   @config[:flags] |= ::Mysql2::Client::FOUND_ROWS
         # end
-
-        @connection_parameters = conn_params
       end
 
       def supports_json?

lib/arjdbc/mysql/adapter_hash_config.rb

@@ -3,8 +3,6 @@
 module ArJdbc
   module MysqlConfig
     def build_connection_config(config)
-      config = config.deep_dup
-
       load_jdbc_driver
 
       # don't set driver if it's explicitly set to false
@@ -61,7 +59,7 @@ def build_properties(config)
 
       properties["connectionCollation"] ||= config[:collation] if config[:collation]
 
-      properties["autoReconnect"] ||= reconnect.to_s unless config[:reconnect].nil?
+      properties["autoReconnect"] ||= reconnect.to_s if config[:reconnect]
 
       properties["noDatetimeStringSync"] = true unless properties.key?("noDatetimeStringSync")