Skip to content

Commit b6cf739

Browse files
authored
Log non-fatal errors in Visualizer as warnings instead of errors (#2579)
1 parent a5c9e2d commit b6cf739

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

cpp/open3d/visualization/visualizer/Visualizer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ class GLFWEnvironmentSingleton {
5757
}
5858

5959
static void GLFWErrorCallback(int error, const char *description) {
60-
utility::LogError("GLFW Error: {}", description);
60+
utility::LogWarning("GLFW Error: {}", description);
6161
}
6262
};
6363

cpp/open3d/visualization/visualizer/VisualizerRender.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ void Visualizer::Render(bool render_screen) {
7373

7474
if (render_screen) {
7575
if (render_fbo_ != 0) {
76-
utility::LogError("Render framebuffer is not released.");
76+
utility::LogWarning("Render framebuffer is not released.");
7777
}
7878

7979
glGenFramebuffers(1, &render_fbo_);
@@ -145,13 +145,13 @@ void Visualizer::ResetViewPoint(bool reset_bounding_box /* = false*/) {
145145
void Visualizer::CopyViewStatusToClipboard() {
146146
ViewParameters current_status;
147147
if (!view_control_ptr_->ConvertToViewParameters(current_status)) {
148-
utility::LogError("Something is wrong copying view status.");
148+
utility::LogWarning("Something is wrong copying view status.");
149149
}
150150
ViewTrajectory trajectory;
151151
trajectory.view_status_.push_back(current_status);
152152
std::string clipboard_string;
153153
if (!io::WriteIJsonConvertibleToJSONString(clipboard_string, trajectory)) {
154-
utility::LogError("Something is wrong copying view status.");
154+
utility::LogWarning("Something is wrong copying view status.");
155155
}
156156
glfwSetClipboardString(window_, clipboard_string.c_str());
157157
}
@@ -163,10 +163,10 @@ void Visualizer::CopyViewStatusFromClipboard() {
163163
ViewTrajectory trajectory;
164164
if (!io::ReadIJsonConvertibleFromJSONString(clipboard_string,
165165
trajectory)) {
166-
utility::LogError("Something is wrong copying view status.");
166+
utility::LogWarning("Something is wrong copying view status.");
167167
}
168168
if (trajectory.view_status_.size() != 1) {
169-
utility::LogError("Something is wrong copying view status.");
169+
utility::LogWarning("Something is wrong copying view status.");
170170
}
171171
view_control_ptr_->ConvertFromViewParameters(
172172
trajectory.view_status_[0]);

0 commit comments

Comments
 (0)