-
Notifications
You must be signed in to change notification settings - Fork 905
feat: Refactor workflows #2946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Refactor workflows #2946
Conversation
4a5fcf5 to
28fe41d
Compare
28fe41d to
0eb0164
Compare
0eb0164 to
28f7574
Compare
nickfloyd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I love the collapse of jobs ❤️ - approving pending completion / this coming out of draft status.
@nickfloyd the draft status is required until the repo level changes are made to keep secrets isolated from pull request target workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments
Signed-off-by: Steve Hipwell <[email protected]>
28f7574 to
c5ad7c1
Compare
Resolves #2425
This PR requires the following changes before it should be merged.
release-v*to maintainersv*pattern to the default branch (main) or branches with the patternrelease-v*releaseenvironment and protect it to tags with the patternv*releaseenvironmentacctestlabelacctest-dotcom&acctest-ghesenvironments and require that they be approved by maintainersDOTCOM_TEST_USER_TOKENtoacctest-dotcomenvironmentGHES_TEST_USER_TOKENtoacctest-ghesenvironmentGHES_TEST_SERVER_HOSTto varsPost Merge
Post Next Release
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!