feat: control CUDA deps #11355
Open
feat: control CUDA deps #11355
+335
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pre-install CPU-only PyTorch to avoid GPU version (saves ~4-5GB) - Add BUILD_MINERU build arg for optional mineru installation - Modify pip_install_torch() to default to CPU-only PyTorch - Update entrypoint to handle CPU-only PyTorch for mineru - Add comprehensive documentation for CUDA optimizations Benefits: - Reduces image size from ~6-8GB to ~2-3GB (60-70% reduction) - Eliminates massive CUDA package downloads during build/runtime - Maintains full functionality with CPU processing - Optional GPU support via GPU_PYTORCH=true environment variable - Significantly faster build times and reduced bandwidth usage Fixes: Docker image downloading tons of CUDA packages unnecessarily
dosubot
bot
added
size:L
- Fix uv pip install syntax to use --python flag instead of incorrect venv activation - Add proper CPU-only PyTorch installation in main and mineru environments - Update entrypoint scripts to check for pre-installed packages first - Ensure proper fallback to runtime installation when needed The previous commit only included documentation files, this commit adds the actual implementation.
Signed-off-by: Björn thorwirth <[email protected]>
Author
|
srry .. firs request was accident .. now it's tested |
yongtenglei
approved these changes
Nov 19, 2025
| return 1 | ||
| else | ||
| echo "[mineru] installed: ${MINERU_EXECUTABLE}" | ||
| return 1 |
Member
There was a problem hiding this comment.
Hi, @moonstruxx
Thank you for your contribution. This looks good to me.
But I think here it should return 0 to indicate that MinerU has been installed successfully. Returning a non-zero value will cause the program to fail unexpectedly. However, since we have the restart: on-failure strategy, it will succeed on the next try.
I personally recommend changing it to express the correct semantic meaning. However, as I said, it doesn't really matter. It's up to you.
Cheers.
Collaborator
|
CI failure. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Benefits:
Fixes: Docker image downloading tons of CUDA packages unnecessarily
Type of change