-
Notifications
You must be signed in to change notification settings - Fork 9.8k
new resource: aws_vpc_encryption_control
#45263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s equivalent to `nil`
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
% make testacc TESTARGS='-run=TestAccVPCVPCEncryptionControl_' PKG=ec2 ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-vpc-encryption-controls 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/ec2/... -v -count 1 -parallel 4 -run=TestAccVPCVPCEncryptionControl_ -timeout 360m -vet=off
2025/11/26 08:55:37 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/26 08:55:37 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN TestAccVPCVPCEncryptionControl_Identity_Basic
=== PAUSE TestAccVPCVPCEncryptionControl_Identity_Basic
=== RUN TestAccVPCVPCEncryptionControl_Identity_RegionOverride
=== PAUSE TestAccVPCVPCEncryptionControl_Identity_RegionOverride
=== RUN TestAccVPCVPCEncryptionControl_tags
=== PAUSE TestAccVPCVPCEncryptionControl_tags
=== RUN TestAccVPCVPCEncryptionControl_tags_null
=== PAUSE TestAccVPCVPCEncryptionControl_tags_null
=== RUN TestAccVPCVPCEncryptionControl_tags_EmptyMap
=== PAUSE TestAccVPCVPCEncryptionControl_tags_EmptyMap
=== RUN TestAccVPCVPCEncryptionControl_tags_AddOnUpdate
=== PAUSE TestAccVPCVPCEncryptionControl_tags_AddOnUpdate
=== RUN TestAccVPCVPCEncryptionControl_tags_EmptyTag_OnCreate
=== PAUSE TestAccVPCVPCEncryptionControl_tags_EmptyTag_OnCreate
=== RUN TestAccVPCVPCEncryptionControl_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccVPCVPCEncryptionControl_tags_EmptyTag_OnUpdate_Add
=== RUN TestAccVPCVPCEncryptionControl_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccVPCVPCEncryptionControl_tags_EmptyTag_OnUpdate_Replace
=== RUN TestAccVPCVPCEncryptionControl_tags_DefaultTags_providerOnly
=== PAUSE TestAccVPCVPCEncryptionControl_tags_DefaultTags_providerOnly
=== RUN TestAccVPCVPCEncryptionControl_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccVPCVPCEncryptionControl_tags_DefaultTags_nonOverlapping
=== RUN TestAccVPCVPCEncryptionControl_tags_DefaultTags_overlapping
=== PAUSE TestAccVPCVPCEncryptionControl_tags_DefaultTags_overlapping
=== RUN TestAccVPCVPCEncryptionControl_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCVPCEncryptionControl_tags_DefaultTags_updateToProviderOnly
=== RUN TestAccVPCVPCEncryptionControl_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCVPCEncryptionControl_tags_DefaultTags_updateToResourceOnly
=== RUN TestAccVPCVPCEncryptionControl_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccVPCVPCEncryptionControl_tags_DefaultTags_emptyResourceTag
=== RUN TestAccVPCVPCEncryptionControl_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccVPCVPCEncryptionControl_tags_DefaultTags_emptyProviderOnlyTag
=== RUN TestAccVPCVPCEncryptionControl_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccVPCVPCEncryptionControl_tags_DefaultTags_nullOverlappingResourceTag
=== RUN TestAccVPCVPCEncryptionControl_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccVPCVPCEncryptionControl_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN TestAccVPCVPCEncryptionControl_tags_ComputedTag_OnCreate
=== PAUSE TestAccVPCVPCEncryptionControl_tags_ComputedTag_OnCreate
=== RUN TestAccVPCVPCEncryptionControl_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccVPCVPCEncryptionControl_tags_ComputedTag_OnUpdate_Add
=== RUN TestAccVPCVPCEncryptionControl_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccVPCVPCEncryptionControl_tags_ComputedTag_OnUpdate_Replace
=== RUN TestAccVPCVPCEncryptionControl_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccVPCVPCEncryptionControl_tags_IgnoreTags_Overlap_DefaultTag
=== RUN TestAccVPCVPCEncryptionControl_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccVPCVPCEncryptionControl_tags_IgnoreTags_Overlap_ResourceTag
=== RUN TestAccVPCVPCEncryptionControl_basic
=== PAUSE TestAccVPCVPCEncryptionControl_basic
=== RUN TestAccVPCVPCEncryptionControl_disappears
=== PAUSE TestAccVPCVPCEncryptionControl_disappears
=== RUN TestAccVPCVPCEncryptionControl_enforce
=== PAUSE TestAccVPCVPCEncryptionControl_enforce
=== RUN TestAccVPCVPCEncryptionControl_enforce_ImplicitExclusions
=== PAUSE TestAccVPCVPCEncryptionControl_enforce_ImplicitExclusions
=== RUN TestAccVPCVPCEncryptionControl_enforce_ExplicitExclusions
=== PAUSE TestAccVPCVPCEncryptionControl_enforce_ExplicitExclusions
=== RUN TestAccVPCVPCEncryptionControl_update_monitorToEnforce
=== PAUSE TestAccVPCVPCEncryptionControl_update_monitorToEnforce
=== RUN TestAccVPCVPCEncryptionControl_update_monitorToEnforce_ImplicitExclusions
=== PAUSE TestAccVPCVPCEncryptionControl_update_monitorToEnforce_ImplicitExclusions
=== RUN TestAccVPCVPCEncryptionControl_update_enforce_ExplictDisableExclusions
=== PAUSE TestAccVPCVPCEncryptionControl_update_enforce_ExplictDisableExclusions
=== RUN TestAccVPCVPCEncryptionControl_update_enforce_ImplicitExclusions
=== PAUSE TestAccVPCVPCEncryptionControl_update_enforce_ImplicitExclusions
=== RUN TestAccVPCVPCEncryptionControl_update_enforceToMonitor
=== PAUSE TestAccVPCVPCEncryptionControl_update_enforceToMonitor
=== RUN TestAccVPCVPCEncryptionControl_WithAssociatedResources_Excludable_monitor
=== PAUSE TestAccVPCVPCEncryptionControl_WithAssociatedResources_Excludable_monitor
=== RUN TestAccVPCVPCEncryptionControl_WithAssociatedResources_Excludable_enforceWithoutExclusion
=== PAUSE TestAccVPCVPCEncryptionControl_WithAssociatedResources_Excludable_enforceWithoutExclusion
=== RUN TestAccVPCVPCEncryptionControl_WithAssociatedResources_Excludable_enforceWithExclusion
=== PAUSE TestAccVPCVPCEncryptionControl_WithAssociatedResources_Excludable_enforceWithExclusion
=== RUN TestAccVPCVPCEncryptionControl_WithAssociatedResources_Migratable_monitor
=== PAUSE TestAccVPCVPCEncryptionControl_WithAssociatedResources_Migratable_monitor
=== RUN TestAccVPCVPCEncryptionControl_WithAssociatedResources_Migratable_enforce
=== PAUSE TestAccVPCVPCEncryptionControl_WithAssociatedResources_Migratable_enforce
=== RUN TestAccVPCVPCEncryptionControl_WithAssociatedResources_Unsupported_monitor
=== PAUSE TestAccVPCVPCEncryptionControl_WithAssociatedResources_Unsupported_monitor
=== RUN TestAccVPCVPCEncryptionControl_WithAssociatedResources_Unsupported_enforce
=== PAUSE TestAccVPCVPCEncryptionControl_WithAssociatedResources_Unsupported_enforce
=== RUN TestAccVPCVPCEncryptionControl_Identity_Enforce
=== PAUSE TestAccVPCVPCEncryptionControl_Identity_Enforce
=== CONT TestAccVPCVPCEncryptionControl_Identity_Basic
=== CONT TestAccVPCVPCEncryptionControl_tags_IgnoreTags_Overlap_DefaultTag
=== CONT TestAccVPCVPCEncryptionControl_tags_DefaultTags_overlapping
=== CONT TestAccVPCVPCEncryptionControl_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccVPCVPCEncryptionControl_tags_DefaultTags_nullOverlappingResourceTag (43.81s)
=== CONT TestAccVPCVPCEncryptionControl_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccVPCVPCEncryptionControl_Identity_Basic (53.51s)
=== CONT TestAccVPCVPCEncryptionControl_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccVPCVPCEncryptionControl_tags_IgnoreTags_Overlap_DefaultTag (63.41s)
=== CONT TestAccVPCVPCEncryptionControl_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccVPCVPCEncryptionControl_tags_DefaultTags_overlapping (75.55s)
=== CONT TestAccVPCVPCEncryptionControl_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccVPCVPCEncryptionControl_tags_ComputedTag_OnUpdate_Add (57.63s)
=== CONT TestAccVPCVPCEncryptionControl_tags_ComputedTag_OnCreate
--- PASS: TestAccVPCVPCEncryptionControl_tags_DefaultTags_emptyResourceTag (42.32s)
=== CONT TestAccVPCVPCEncryptionControl_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPCVPCEncryptionControl_tags_ComputedTag_OnUpdate_Replace (57.65s)
=== CONT TestAccVPCVPCEncryptionControl_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPCVPCEncryptionControl_tags_DefaultTags_emptyProviderOnlyTag (43.12s)
=== CONT TestAccVPCVPCEncryptionControl_update_enforce_ImplicitExclusions
--- PASS: TestAccVPCVPCEncryptionControl_tags_ComputedTag_OnCreate (45.52s)
=== CONT TestAccVPCVPCEncryptionControl_Identity_Enforce
--- PASS: TestAccVPCVPCEncryptionControl_tags_DefaultTags_updateToResourceOnly (55.82s)
=== CONT TestAccVPCVPCEncryptionControl_WithAssociatedResources_Unsupported_enforce
--- PASS: TestAccVPCVPCEncryptionControl_tags_DefaultTags_updateToProviderOnly (55.62s)
=== CONT TestAccVPCVPCEncryptionControl_WithAssociatedResources_Unsupported_monitor
--- PASS: TestAccVPCVPCEncryptionControl_WithAssociatedResources_Unsupported_monitor (493.83s)
=== CONT TestAccVPCVPCEncryptionControl_WithAssociatedResources_Migratable_enforce
--- PASS: TestAccVPCVPCEncryptionControl_Identity_Enforce (958.25s)
=== CONT TestAccVPCVPCEncryptionControl_WithAssociatedResources_Migratable_monitor
--- PASS: TestAccVPCVPCEncryptionControl_update_enforce_ImplicitExclusions (964.58s)
=== CONT TestAccVPCVPCEncryptionControl_WithAssociatedResources_Excludable_enforceWithExclusion
--- PASS: TestAccVPCVPCEncryptionControl_WithAssociatedResources_Migratable_monitor (245.36s)
=== CONT TestAccVPCVPCEncryptionControl_WithAssociatedResources_Excludable_enforceWithoutExclusion
--- PASS: TestAccVPCVPCEncryptionControl_WithAssociatedResources_Excludable_enforceWithoutExclusion (56.71s)
=== CONT TestAccVPCVPCEncryptionControl_WithAssociatedResources_Excludable_monitor
--- PASS: TestAccVPCVPCEncryptionControl_WithAssociatedResources_Excludable_monitor (53.92s)
=== CONT TestAccVPCVPCEncryptionControl_update_enforceToMonitor
--- PASS: TestAccVPCVPCEncryptionControl_WithAssociatedResources_Unsupported_enforce (1379.85s)
=== CONT TestAccVPCVPCEncryptionControl_tags_EmptyTag_OnCreate
--- PASS: TestAccVPCVPCEncryptionControl_tags_EmptyTag_OnCreate (56.10s)
=== CONT TestAccVPCVPCEncryptionControl_tags_DefaultTags_nonOverlapping
--- PASS: TestAccVPCVPCEncryptionControl_tags_DefaultTags_nonOverlapping (73.32s)
=== CONT TestAccVPCVPCEncryptionControl_tags_DefaultTags_providerOnly
--- PASS: TestAccVPCVPCEncryptionControl_tags_DefaultTags_providerOnly (87.54s)
=== CONT TestAccVPCVPCEncryptionControl_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccVPCVPCEncryptionControl_tags_EmptyTag_OnUpdate_Replace (54.16s)
=== CONT TestAccVPCVPCEncryptionControl_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccVPCVPCEncryptionControl_WithAssociatedResources_Excludable_enforceWithExclusion (757.05s)
=== CONT TestAccVPCVPCEncryptionControl_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccVPCVPCEncryptionControl_tags_DefaultTags_nullNonOverlappingResourceTag (43.11s)
=== CONT TestAccVPCVPCEncryptionControl_enforce_ImplicitExclusions
--- PASS: TestAccVPCVPCEncryptionControl_update_enforceToMonitor (418.39s)
=== CONT TestAccVPCVPCEncryptionControl_disappears
--- PASS: TestAccVPCVPCEncryptionControl_disappears (39.67s)
=== CONT TestAccVPCVPCEncryptionControl_update_enforce_ExplictDisableExclusions
--- PASS: TestAccVPCVPCEncryptionControl_tags_EmptyTag_OnUpdate_Add (70.60s)
=== CONT TestAccVPCVPCEncryptionControl_enforce
--- PASS: TestAccVPCVPCEncryptionControl_enforce_ImplicitExclusions (464.76s)
=== CONT TestAccVPCVPCEncryptionControl_update_monitorToEnforce_ImplicitExclusions
--- PASS: TestAccVPCVPCEncryptionControl_update_enforce_ExplictDisableExclusions (471.32s)
=== CONT TestAccVPCVPCEncryptionControl_update_monitorToEnforce
--- PASS: TestAccVPCVPCEncryptionControl_enforce (463.57s)
=== CONT TestAccVPCVPCEncryptionControl_enforce_ExplicitExclusions
=== NAME TestAccVPCVPCEncryptionControl_WithAssociatedResources_Migratable_enforce
vpc_encryption_control_test.go:1011: Step 2/3 error: Error running apply: exit status 1
Error: creating EC2 (Elastic Compute Cloud) VPC Encryption Control
with aws_vpc_encryption_control.test,
on terraform_plugin_test.tf line 40, in resource "aws_vpc_encryption_control" "test":
40: resource "aws_vpc_encryption_control" "test" {
Cause: While waiting, timeout while waiting for state to become 'TRUE' (last
state: 'FALSE', timeout: 30m0s)"
--- FAIL: TestAccVPCVPCEncryptionControl_WithAssociatedResources_Migratable_enforce (2078.88s)
=== CONT TestAccVPCVPCEncryptionControl_tags_null
--- PASS: TestAccVPCVPCEncryptionControl_tags_null (43.31s)
=== CONT TestAccVPCVPCEncryptionControl_basic
--- PASS: TestAccVPCVPCEncryptionControl_basic (42.28s)
=== CONT TestAccVPCVPCEncryptionControl_tags_AddOnUpdate
--- PASS: TestAccVPCVPCEncryptionControl_tags_AddOnUpdate (55.27s)
=== CONT TestAccVPCVPCEncryptionControl_tags_EmptyMap
--- PASS: TestAccVPCVPCEncryptionControl_tags_EmptyMap (43.27s)
=== CONT TestAccVPCVPCEncryptionControl_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccVPCVPCEncryptionControl_tags_IgnoreTags_Overlap_ResourceTag (65.13s)
=== CONT TestAccVPCVPCEncryptionControl_tags
--- PASS: TestAccVPCVPCEncryptionControl_tags (84.61s)
=== CONT TestAccVPCVPCEncryptionControl_Identity_RegionOverride
--- PASS: TestAccVPCVPCEncryptionControl_Identity_RegionOverride (45.99s)
--- PASS: TestAccVPCVPCEncryptionControl_update_monitorToEnforce_ImplicitExclusions (960.64s)
--- PASS: TestAccVPCVPCEncryptionControl_enforce_ExplicitExclusions (949.98s)
--- PASS: TestAccVPCVPCEncryptionControl_update_monitorToEnforce (962.63s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/ec2 3335.603s
FAIL
make: *** [testacc] Error 1 |
f681359 to
bb55278
Compare
ewbankkit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
|
This functionality has been released in v6.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
@ewbankkit shouldnt there be support for aws_ec2_transit_gateway for encryption support? |
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Adds new resource type
aws_vpc_encryption_control.Relations
Closes #45208.
Output from Acceptance Testing