UI/ember upgrade to v4.12 #23070
Open
UI/ember upgrade to v4.12 #23070
+3,602
−5,869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabh-gupta-hashicorp
added
the
backport/all
rishabh-gupta-hashicorp
changed the title
deanmarano
reviewed
Nov 25, 2025
| "ember-data": "~3.28.6", | ||
| "ember-data-model-fragments": "5.0.0-beta.8", | ||
| "ember-data": "~4.0.0", | ||
| "ember-data-model-fragments": "6.0.10", |
There was a problem hiding this comment.
I would recommend matching ember-data-model-fragments 6.0.10 with ember-data 4.6.7 - that is the intended pairing.
deanmarano
reviewed
Nov 25, 2025
| @color='critical' | ||
| data-test-delete | ||
| {{on 'click' (fn confirm )}} | ||
| {{on 'click' confirm }} |
There was a problem hiding this comment.
I think this should be this.confirm to reference the component. Also the same for the cancel below.
Contributor
There was a problem hiding this comment.
confirm is trickling down as return value from the wrapping BlockSlot. It's not part of this object.
deanmarano
reviewed
Nov 25, 2025
| @color='critical' | ||
| @text='Delete' | ||
| {{on "click" (fn confirm )}} | ||
| {{on "click" confirm }} |
There was a problem hiding this comment.
I think this should be tied to the component action using this.
Suggested change
| {{on "click" confirm }} | |
| {{on "click" this.confirm }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades Ember from v3.28 to v4.12
Along with Ember upgrade, the PR upgrades multiple other packages and fixes some more deprecations.
Multiple Code Refactoring and Linting changes to follow best practices for v4.12 as well as paves the way for version upgrade to v5.
Testing & Reproduction steps
Links
PR Checklist
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.