Skip to content

Commit 753ed1b

Browse files
xds: Avoid using empty SNI string that was never sent, for SAN validation (#12532)
1 parent 97695d5 commit 753ed1b

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

xds/src/main/java/io/grpc/xds/internal/security/SecurityProtocolNegotiators.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,8 +219,10 @@ public void handlerAdded(ChannelHandlerContext ctx) throws Exception {
219219
String sniToUse = upstreamTlsContext.getAutoHostSni()
220220
&& !Strings.isNullOrEmpty(endpointHostname)
221221
? endpointHostname : upstreamTlsContext.getSni();
222-
if (sniToUse.isEmpty() && CertificateUtils.useChannelAuthorityIfNoSniApplicable) {
223-
sniToUse = grpcHandler.getAuthority();
222+
if (sniToUse.isEmpty()) {
223+
if (CertificateUtils.useChannelAuthorityIfNoSniApplicable) {
224+
sniToUse = grpcHandler.getAuthority();
225+
}
224226
autoSniSanValidationDoesNotApply = true;
225227
} else {
226228
autoSniSanValidationDoesNotApply = false;

0 commit comments

Comments
 (0)