Skip to content

Commit 7ed0b61

Browse files
authored
Merge pull request #113251 from van800/master
Revert "Improve the CPP dialect selection for Rider, when MSVC is not used"
2 parents a2db180 + 8c93de8 commit 7ed0b61

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

misc/msvs/nmake.substitution.props

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,10 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33
<PropertyGroup>
4+
<!-- override the PlatformToolset, which is set in the godot.vcxproj-->
5+
<!-- Unknown matches to a set of conservative rules for the code analysis-->
6+
<PlatformToolset>Unknown</PlatformToolset>
47
<LocalDebuggerCommand Condition="'$(LocalDebuggerCommand)' == ''">$(NMakeOutput)</LocalDebuggerCommand>
5-
6-
<!-- Possible values: V143, Clang_Mac, Clang_Linux, llvm, Clang, ClangCL, MSFS, Unknown-->
7-
<!-- Select toolset based on target GodotPlatform. Switches Cpp dialect -->
8-
<PlatformToolset Condition="'$(GodotPlatform)'=='windows'">v143</PlatformToolset>
9-
<PlatformToolset Condition="'$(GodotPlatform)'=='macos' or '$(GodotPlatform)'=='ios'">Clang_Mac</PlatformToolset>
10-
<PlatformToolset Condition="'$(GodotPlatform)'=='linux'">Clang_Linux</PlatformToolset>
11-
<PlatformToolset Condition="'$(GodotPlatform)'=='android'">Clang_Linux</PlatformToolset>
12-
<PlatformToolset Condition="'$(GodotPlatform)'=='web'">Clang_Linux</PlatformToolset>
13-
<!-- Fallback -->
14-
<PlatformToolset Condition="'$(PlatformToolset)'==''">Unknown</PlatformToolset>
15-
168
</PropertyGroup>
179
<!-- Build/Rebuild/Clean targets for NMake are defined in MSVC, so we need to provide them, when using MSBuild without MSVC targets -->
1810
<Target Name="Build">

0 commit comments

Comments
 (0)