feat(ci): Ensure self-hosted e2e tests run on PR's #7468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldy505
reviewed
Oct 23, 2025
Comment on lines
+449
to
+452
| self-hosted-end-to-end: | ||
| needs: [snuba-image, files-changed] | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 30 |
Collaborator
There was a problem hiding this comment.
Can we only run this when it's ${{ github.event_name == 'pull_request' }}, and keep the one on image.yml file to test it with an actual pushed GHCR Docker image?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self-hosted e2e tests were not run on PR's, and we needed to fix with #7466. This ensures it runs