address pr comments

Author: nicohrubec

packages/core/test/lib/tracing/trace.test.ts

@@ -2023,7 +2023,7 @@ describe('continueTrace', () => {
     });
   });
 
-  it('works inside an active span', () => {
+  it('updates the propagation context when called inside an active span', () => {
     const client = new TestClient(
       getDefaultTestClientOptions({
         dsn: 'https://username@domain/123',
@@ -2055,6 +2055,41 @@ describe('continueTrace', () => {
       );
     });
   });
+
+  it('sets the correct trace and parent span ids when called inside an active span and a new span is started from within the callback', () => {
+    const client = new TestClient(
+      getDefaultTestClientOptions({
+        dsn: 'https://username@domain/123',
+        tracesSampleRate: 1,
+      }),
+    );
+    setCurrentClient(client);
+    client.init();
+
+    const sentryTrace = '12312012123120121231201212312012-1121201211212012-1';
+    const sentryTraceId = '12312012123120121231201212312012';
+    const sentrySpanId = '1121201211212012';
+    const sentryBaggage = 'sentry-org_id=123';
+
+    startSpan({ name: 'outer' }, () => {
+      continueTrace(
+        {
+          sentryTrace: sentryTrace,
+          baggage: sentryBaggage,
+        },
+        () => {
+          startSpan({ name: 'inner' }, (span) => {
+            const innerSpanJson = spanToJSON(span);
+            const innerTraceId = innerSpanJson.trace_id;
+            const innerParentSpanId = innerSpanJson.parent_span_id;
+
+            expect(innerTraceId).toBe(sentryTraceId);
+            expect(innerParentSpanId).toBe(sentrySpanId);
+          });
+        },
+      );
+    });
+  });
 });
 
 describe('getActiveSpan', () => {