Fix incorrect ordering in PendingAttestation, Attestation, Eth1Data #4768
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorrect ordering was confusing and can cause clients to implement wrongly the following functions.
According to the structure in the specifications
datashould be the 2nd parameter:consensus-specs/specs/phase0/beacon-chain.md
Lines 426 to 430 in c20c1bd
committee_bitsshould be the 4th parameter:consensus-specs/specs/electra/beacon-chain.md
Lines 351 to 357 in c20c1bd
deposit_countcomes first prior toblock_hash.consensus-specs/specs/phase0/beacon-chain.md
Lines 436 to 439 in c20c1bd