Add null checks for Logs locators (#242116)

Resolves
elastic/observability-error-backlog#116

We're seeing a few `TypeError: Cannot read properties of undefined
(reading 'getRedirectUrl')` errors coming from Kibana, specifically from
`logs` app.

Most of the errors are coming from clusters on `8.15`, it's hard to
pinpoint the specific code that triggers the error as there are no stack
traces, but `get_logs_locators.ts` file seems like it could be the root
cause as it has non-null assertions.

While `8.15`-`8.18` branchs are already closed and we cannot fix it
there, the same code is present in `8.19` versions as well.

I've removed the assertions and adjusted the code to expect optional
locators and fallback gracefully.

Author: mykolaharmash

x-pack/platform/plugins/shared/fleet/public/custom_logs_assets_extension.tsx

@@ -24,7 +24,7 @@ export const CustomLogsAssetsExtension: PackageAssetsComponent = () => {
   const views: CustomAssetsAccordionProps['views'] = [
     {
       name: i18n.translate('xpack.fleet.assets.customLogs.name', { defaultMessage: 'Logs' }),
-      url: logsLocator.getRedirectUrl({}),
+      url: logsLocator?.getRedirectUrl({}) ?? '',
       description: i18n.translate('xpack.fleet.assets.customLogs.description', {
         defaultMessage: 'View Custom logs data in Logs Explorer',
       }),

x-pack/platform/plugins/shared/logs_shared/common/locators/get_logs_locators.ts

@@ -15,10 +15,10 @@ import { TRACE_LOGS_LOCATOR_ID } from './trace_logs_locator';
 
 export const getLogsLocatorsFromUrlService = (urlService: UrlService) => {
   const discoverLogsLocator =
-    urlService.locators.get<DiscoverLogsLocatorParams>(DISCOVER_LOGS_LOCATOR_ID)!;
-  const logsLocator = urlService.locators.get<LogsLocatorParams>(LOGS_LOCATOR_ID)!;
-  const nodeLogsLocator = urlService.locators.get<NodeLogsLocatorParams>(NODE_LOGS_LOCATOR_ID)!;
-  const traceLogsLocator = urlService.locators.get<TraceLogsLocatorParams>(TRACE_LOGS_LOCATOR_ID)!;
+    urlService.locators.get<DiscoverLogsLocatorParams>(DISCOVER_LOGS_LOCATOR_ID);
+  const logsLocator = urlService.locators.get<LogsLocatorParams>(LOGS_LOCATOR_ID);
+  const nodeLogsLocator = urlService.locators.get<NodeLogsLocatorParams>(NODE_LOGS_LOCATOR_ID);
+  const traceLogsLocator = urlService.locators.get<TraceLogsLocatorParams>(TRACE_LOGS_LOCATOR_ID);
 
   return {
     discoverLogsLocator,

x-pack/solutions/observability/plugins/apm/public/components/app/service_overview/service_overview_instances_table/instance_actions_menu/menu_sections.ts

@@ -50,7 +50,7 @@ export function getMenuSections({
   onFilterByInstanceClick: () => void;
   metricsHref: string;
   allDatasetsLocator: LocatorPublic<AllDatasetsLocatorParams>;
-  nodeLogsLocator: LocatorPublic<NodeLogsLocatorParams>;
+  nodeLogsLocator?: LocatorPublic<NodeLogsLocatorParams>;
   assetDetailsLocator?: AssetDetailsLocator;
 }) {
   const podId = instanceDetails.kubernetes?.pod?.uid;
@@ -60,13 +60,13 @@ export function getMenuSections({
     : undefined;
   const infraMetricsQuery = getInfraMetricsQuery(instanceDetails['@timestamp']);
 
-  const podLogsHref = nodeLogsLocator.getRedirectUrl({
+  const podLogsHref = nodeLogsLocator?.getRedirectUrl({
     nodeField: findInventoryFields('pod').id,
     nodeId: podId!,
     time,
   });
 
-  const containerLogsHref = nodeLogsLocator.getRedirectUrl({
+  const containerLogsHref = nodeLogsLocator?.getRedirectUrl({
     nodeField: findInventoryFields('container').id,
     nodeId: containerId!,
     time,

x-pack/solutions/observability/plugins/apm/public/components/shared/transaction_action_menu/sections.ts

@@ -85,23 +85,23 @@ export const getSections = ({
   );
 
   // Logs hrefs
-  const podLogsHref = logsLocators.nodeLogsLocator.getRedirectUrl({
+  const podLogsHref = logsLocators.nodeLogsLocator?.getRedirectUrl({
     nodeField: findInventoryFields('pod').id,
     nodeId: podId!,
     time,
   });
-  const containerLogsHref = logsLocators.nodeLogsLocator.getRedirectUrl({
+  const containerLogsHref = logsLocators.nodeLogsLocator?.getRedirectUrl({
     nodeField: findInventoryFields('container').id,
     nodeId: containerId!,
     time,
   });
-  const hostLogsHref = logsLocators.nodeLogsLocator.getRedirectUrl({
+  const hostLogsHref = logsLocators.nodeLogsLocator?.getRedirectUrl({
     nodeField: findInventoryFields('host').id,
     nodeId: hostName!,
     time,
   });
 
-  const traceLogsHref = logsLocators.traceLogsLocator.getRedirectUrl({
+  const traceLogsHref = logsLocators.traceLogsLocator?.getRedirectUrl({
     traceId: transaction.trace.id!,
     time,
   });

x-pack/solutions/observability/plugins/infra/public/alerting/log_threshold/log_threshold_rule_type.tsx

@@ -34,7 +34,7 @@ const logThresholdDefaultRecoveryMessage = i18n.translate(
   'xpack.infra.logs.alerting.threshold.defaultRecoveryMessage',
   {
     defaultMessage: `Recovered: '{{context.reason}}'
-    
+
     '{{rule.name}}' has recovered.
 
 [View alert details]('{{context.alertDetailsUrl}}')
@@ -73,7 +73,7 @@ export function createLogThresholdRuleType(
     defaultActionMessage: logThresholdDefaultActionMessage,
     defaultRecoveryMessage: logThresholdDefaultRecoveryMessage,
     requiresAppContext: false,
-    format: createRuleFormatter(logsLocator),
+    format: logsLocator ? createRuleFormatter(logsLocator) : () => ({ reason: '' }),
     priority: 30,
   };
 }

x-pack/solutions/observability/plugins/infra/public/components/asset_details/tabs/logs/logs.tsx

@@ -42,7 +42,7 @@ export const Logs = () => {
       share: { url },
     },
   } = useKibanaContextForPlugin();
-  const { logsLocator } = getLogsLocatorsFromUrlService(url)!;
+  const { logsLocator } = getLogsLocatorsFromUrlService(url);
   const [textQuery, setTextQuery] = useState(urlState?.logsSearch ?? '');
   const [textQueryDebounced, setTextQueryDebounced] = useState(urlState?.logsSearch ?? '');
 
@@ -87,7 +87,7 @@ export const Logs = () => {
       nodeId: asset.id,
       filter: textQueryDebounced,
     });
-    return logsLocator.getRedirectUrl({
+    return logsLocator?.getRedirectUrl({
       filter: nodeQuery.query,
       timeRange: {
         startTime: state.startTimestamp,

x-pack/solutions/observability/plugins/infra/public/pages/link_to/redirect_to_logs.tsx

@@ -23,7 +23,7 @@ export const RedirectToLogs = () => {
   const time = getTimeFromLocation(location);
 
   useEffect(() => {
-    logsLocator.navigate(
+    logsLocator?.navigate(
       {
         time,
         filter,

x-pack/solutions/observability/plugins/infra/public/pages/link_to/redirect_to_node_logs.tsx

@@ -35,7 +35,7 @@ export const RedirectToNodeLogs = ({
   const time = getTimeFromLocation(location);
 
   useEffect(() => {
-    nodeLogsLocator.navigate(
+    nodeLogsLocator?.navigate(
       {
         nodeField: findInventoryFields(nodeType).id,
         nodeId,

x-pack/solutions/observability/plugins/infra/public/pages/metrics/inventory_view/components/waffle/node_context_menu.tsx

@@ -124,7 +124,7 @@ export const NodeContextMenu: React.FC<Props & { theme?: EuiTheme }> = withTheme
         defaultMessage: '{inventoryName} logs',
         values: { inventoryName: inventoryModel.singularDisplayName },
       }),
-      href: nodeLogsLocator.getRedirectUrl({
+      href: nodeLogsLocator?.getRedirectUrl({
         nodeField: findInventoryFields(nodeType).id,
         nodeId: node.id,
         time: currentTime,

x-pack/solutions/observability/plugins/infra/public/utils/logs_overview_fetchers.ts

@@ -70,12 +70,13 @@ export function getLogsOverviewDataFetcher(
     const { logsLocator } = getLogsLocatorsFromUrlService(share.url);
     const timeSpanInMinutes = (params.absoluteTime.end - params.absoluteTime.start) / (1000 * 60);
 
-    const appLink = logsLocator.getRedirectUrl({
-      timeRange: {
-        startTime: params.absoluteTime.start,
-        endTime: params.absoluteTime.end,
-      },
-    });
+    const appLink =
+      logsLocator?.getRedirectUrl({
+        timeRange: {
+          startTime: params.absoluteTime.start,
+          endTime: params.absoluteTime.end,
+        },
+      }) ?? '';
 
     return {
       appLink,