-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomersprotocolSpecification of protocolSpecification of protocolproxysdksSupport languagesSupport languages
Milestone
Description
Describe the bug
The protocol defines some types for workflos events such as pipes and forwards that do not have all the attributes so that it is possible to identify the target actor.
I suggest that we change to use the ActorId in these types
At the moment:
// Sends the output of a action of an Actor to the input of another action of an Actor
// Useful for handle `pipes` pattern:
// https://www.enterpriseintegrationpatterns.com/patterns/messaging/PipesAndFilters.html
message Pipe {
// Target Actor
string actor = 1;
// Action.
string action_name = 2;
}
// Sends the input of a action of an Actor to the input of another action of an Actor
// Useful for handle `content-basead router` pattern
// https://www.enterpriseintegrationpatterns.com/patterns/messaging/ContentBasedRouter.html
message Forward {
// Target Actor
string actor = 1;
// Action.
string action_name = 2;
}Improvement suggestion:
// Sends the output of a action of an Actor to the input of another action of an Actor
// Useful for handle `pipes` pattern:
// https://www.enterpriseintegrationpatterns.com/patterns/messaging/PipesAndFilters.html
message Pipe {
// Target Actor
eigr.functions.protocol.actors.ActorId actor = 1;
// Action.
string action_name = 2;
}
// Sends the input of a action of an Actor to the input of another action of an Actor
// Useful for handle `content-basead router` pattern
// https://www.enterpriseintegrationpatterns.com/patterns/messaging/ContentBasedRouter.html
message Forward {
// Target Actor
eigr.functions.protocol.actors.ActorId actor = 1;
// Action.
string action_name = 2;
}ping @eliasdarruda @marcellanz
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomersprotocolSpecification of protocolSpecification of protocolproxysdksSupport languagesSupport languages