add find-tool embeddings #258
Draft
+7,526
−449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimslenderslacks
force-pushed
the
slim/embeddings
branch
3 times, most recently
from
024ab72 to
71105ed
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| tarReader := tar.NewReader(rc) | ||
|
|
||
| for { | ||
| header, err := tarReader.Next() |
Check failure
Code scanning / CodeQL
Arbitrary file access during archive extraction ("Zip Slip") High
| return fmt.Errorf("failed to read tar header: %w", err) | ||
| } | ||
|
|
||
| target := filepath.Join(destDir, header.Name) |
Check failure
Code scanning / CodeQL
Arbitrary file write extracting an archive containing symbolic links High
|
|
||
| case tar.TypeSymlink: | ||
| // Handle symlinks | ||
| if err := os.Symlink(header.Linkname, target); err != nil { |
Check failure
Code scanning / CodeQL
Arbitrary file write extracting an archive containing symbolic links High
slimslenderslacks
force-pushed
the
slim/embeddings
branch
from
71105ed to
7d62beb
Compare
slimslenderslacks
force-pushed
the
slim/embeddings
branch
from
7d62beb to
5097bc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several improvements to the embeddings feature and adds new profile management capabilities to the MCP Gateway.
Embeddings Infrastructure Improvements
Container Lifecycle Management: Fixed a critical resource leak where Docker containers spawned by the embeddings client were not being
properly cleaned up on shutdown. The VectorDBClient.Close() method now uses docker stop to gracefully terminate containers and properly
reaps processes, preventing orphaned containers from accumulating. Added comprehensive tests to verify container cleanup behavior.
Configurable Vector Dimensions: Added a dimension parameter to NewVectorDBClient() with a default value of 1536, allowing future
flexibility for different embedding models. Updated all callers and added test coverage for various dimension values including edge
cases.
Conditional Tool Registration: The find-tools dynamic tool (AI-powered tool recommendation) is now only registered when the embeddings
client is successfully configured, preventing confusing errors when embeddings support is unavailable.
Configuration Validation Enhancement
Refactored the mcp-config-set tool to accept and validate complete configuration objects instead of individual key-value pairs. The
tool now validates the entire config object against the server's JSON schema and returns detailed validation errors with the full
schema when validation fails, enabling agents to self-correct configuration mistakes.
Profile Management
Added a new mcp-create-profile dynamic tool that captures the current gateway state (all enabled servers, their configurations, and
tool selections) into a reusable profile. Profiles can be created or updated, providing a snapshot mechanism for quickly restoring or
sharing gateway configurations. The implementation integrates with the existing working set/profile database infrastructure and
includes full validation.