fix(build): link proper cxx std libraries on windows-gnu{,llvm} #1880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ognevny
force-pushed
the
windows-gnu-libs
branch
from
6123e21 to
ace30be
Compare
`*-pc-windows-gnullvm` targets use Clang toolchain, so the std library for it is libc++, pthread is needed to be explicitly linked too. `*-pc-windows-gnu` build also depends on `libatomic`
ognevny
force-pushed
the
windows-gnu-libs
branch
from
ace30be to
8c807d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*-pc-windows-gnullvmtargets use Clang toolchain, so the std library for it is libc++, pthread is needed to be explicitly linked too.*-pc-windows-gnubuild also depends onlibatomic