fix: don't prevent onChange event bubbling to tablist

milan-w · milan-w · commit 85ac495e3b4e · 2025-11-20T17:45:47.000+01:00
diff --git a/packages/components/src/components/tab-item/tab-item.lite.tsx b/packages/components/src/components/tab-item/tab-item.lite.tsx
@@ -30,6 +30,7 @@ export default function DBTabItem(props: DBTabItemProps) {
 	const _ref = useRef<HTMLInputElement | any>(null);
 
 	function setSelectedOnChange(event: any) {
+		event.stopPropagation();
 		useTarget({
 			stencil: () => {
 				state._selected = getBooleanAsString(event.target === _ref);
@@ -58,7 +59,6 @@ export default function DBTabItem(props: DBTabItemProps) {
 			}
 		},
 		handleChange: (event: any) => {
-			event.stopPropagation();
 			if (props.onChange) {
 				props.onChange(event);
 			}

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,7 @@ export default function DBTabItem(props: DBTabItemProps) {`
`30`	`30`	`const _ref = useRef<HTMLInputElement \| any>(null);`
`31`	`31`
`32`	`32`	`function setSelectedOnChange(event: any) {`
	`33`	`+ event.stopPropagation();`
`33`	`34`	`useTarget({`
`34`	`35`	`stencil: () => {`
`35`	`36`	`state._selected = getBooleanAsString(event.target === _ref);`
`@@ -58,7 +59,6 @@ export default function DBTabItem(props: DBTabItemProps) {`
`58`	`59`	`}`
`59`	`60`	`},`
`60`	`61`	`handleChange: (event: any) => {`
`61`		`- event.stopPropagation();`
`62`	`62`	`if (props.onChange) {`
`63`	`63`	`props.onChange(event);`
`64`	`64`	`}`