Skip to content

Conversation

@evsar3
Copy link

@evsar3 evsar3 commented Jan 26, 2023

This PR allow users to also use IP addresses as domain options while generating certificates.

Eg.:

import * as devcert from 'devcert'

const ssl = await devcert.certificateFor([
  'somedomain.local',
  'localhost',
  '192.168.1.2',
  '127.0.0.1'
])

PS.: It would be much less changes, but my VS Code has the organizeImports feature enable, so when I saved the files it have sorted and organized the imports. If that's a problem, I can undo this before merge (if you want).

Congratulations for the great tool. 😄

@miguelcobain
Copy link

Would love to see this merged. It would help a lot for local network tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants