Locale-aware DefaultParameterTransformer (2nd propose) #3123
+113
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2025
antagoony
force-pushed
the
feature/adapt-locale-parameter-by-type-transformer-of-cucumber-expressions
branch
from
22e9a6b to
dae622e
Compare
Contributor
Author
|
According to my comment within the origin issue I investigated for a more generic solution -- and I think I found one. In result, I close this PR and will propose a new one very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Following the discussion of Getting knowledge about the current Locale within any custom @DefaultParameterTransformer plus your responses within my first propose, this is the new PR providing the feature's
Localeinformation for@DefaultParameterTransformermethods.Similar to the 1st approach, this PR adds support for two more method signatures as your propose but now refers to the
LocaleParameterByTypeTransformerthat will be merged into "cucumber/cucumber-expressions" by this PR separately.Since I do not know the version of the upcoming "cucumber-expressions" release, I used a "18.0.2-SNAPSHOT" locally to see everything works fine. This PR must either be released simultaneously with the
LocaleParameterByTypeTransformerPR or must even wait for a new "cucumber-expressions" release before being merged.Please note, this is also the reason why the automatic build (see below) will fail. Currently, the
LocaleParameterByTypeTransformercannot be found and compiling should fail obviously.⚡️ What's your motivation?
See issue "Getting knowledge about the current Locale within any custom @DefaultParameterTransformer" (cucumber/cucumber-expressions#376).
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Yes, please see this this comment within the origin issue.
📋 Checklist: