[TCE] update CSS for double column TOC #4969
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on the Italian TCE, I had to fix the table of contents (TOC) for the phone/tablet device sizes. After checking, it looks like this menu is misaligned for most languages. I have updated the flexbox CSS to: - set the header for the menu to full width - with the header a full width, the two columns now wrap to the next flexbox row. - I set each of the columns to take up 47.5% of the row (this leaves 5% leftover on the row) - I set the `justify-content: space-between' so that the 5% leftover becomes a gap between the columns. The `text-align: start' and `text-indent: 10px hanging' achieve a similar visual effect as the previous `text-indent: -5vw', without breaking out of the box boundaries.
Bargraph6
requested review from
astronaut-wannabe,
bookis,
eliduke,
evanphx,
guitsaru,
just1602 and
veganstraightedge
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
While working on the Italian TCE, I had to fix the table of contents (TOC) for the phone/tablet device sizes.
After checking, it looks like this menu is misaligned for most languages.
I have updated the flexbox CSS to:
set the header for the menu to full width
with the header a full width, the two columns now wrap to the next flexbox row.
I set each of the columns to take up 47.5% of the row (this leaves 5% leftover on the row)
I set the
justify-content: space-betweenso that the 5% leftover becomes a gap between the columns.The
text-align: startandtext-indent: 10px hangingachieve a similar visual effect as the previoustext-indent: -5vw, without breaking out of the box boundaries.How should this be manually tested?
Comparing the table of contents on to change everything across various device sizes and languages with and without the patch
Is there any background context you want to provide for reviewers?
Screenshots