Skip to content

[TCE] fix reconciling-large image #4956

@Bargraph6

Description

@Bargraph6

While working on the italian version, I noticed the image stored
in the CDN for "reconciling-large" is the incorrect size.

This results in the "reconciling" panel to have grey bars at certain
screen sizes.

I generated a new image with the correct dimensions, which can be
uploaded to the CDN.

Local testing

To test locally:

  1. observe the grey bars by setting the screen dimensions to 1280x800
    (DPR 1) in the browser dev tools
  2. put the fixed image in the website/public/tce/images/ directory.
  3. apply this patch to load have the local image loaded (0001-TCE-fix-reconciling-large-image.patch also includes the image in the patch file)
    diff --git a/app/helpers/to_change_everything_helper.rb b/app/helpers/to_change_everything_helper.rb
    index a76f4d309..c801ab781 100644
    --- a/app/helpers/to_change_everything_helper.rb
    +++ b/app/helpers/to_change_everything_helper.rb
    @@ -82,7 +82,12 @@ module ToChangeEverythingHelper
       end
    
       def url_for_tce_image *pieces
    -    [IMAGE_BASE_URL, pieces].join
    +    url = [IMAGE_BASE_URL, pieces].join
    +    if url.include? "reconciling-large"
    +      '/tce/images/reconciling-large.jpg'
    +    else
    +      url
    +    end
       end
    
       def tce_image_tag filename
  4. reload the page and see the grey bars disappear

before/after screenshots

before after
before after

corrected image

reconciling-large.jpg
corrected reconciling-large

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions