-
-
Notifications
You must be signed in to change notification settings - Fork 32
Open
Description
While working on the italian version, I noticed the image stored
in the CDN for "reconciling-large" is the incorrect size.
This results in the "reconciling" panel to have grey bars at certain
screen sizes.
I generated a new image with the correct dimensions, which can be
uploaded to the CDN.
Local testing
To test locally:
- observe the grey bars by setting the screen dimensions to 1280x800
(DPR 1) in the browser dev tools - put the fixed image in the
website/public/tce/images/directory. - apply this patch to load have the local image loaded (0001-TCE-fix-reconciling-large-image.patch also includes the image in the patch file)
diff --git a/app/helpers/to_change_everything_helper.rb b/app/helpers/to_change_everything_helper.rb index a76f4d309..c801ab781 100644 --- a/app/helpers/to_change_everything_helper.rb +++ b/app/helpers/to_change_everything_helper.rb @@ -82,7 +82,12 @@ module ToChangeEverythingHelper end def url_for_tce_image *pieces - [IMAGE_BASE_URL, pieces].join + url = [IMAGE_BASE_URL, pieces].join + if url.include? "reconciling-large" + '/tce/images/reconciling-large.jpg' + else + url + end end def tce_image_tag filename
- reload the page and see the grey bars disappear
before/after screenshots
| before | after |
|---|---|
![]() |
![]() |
corrected image
reconciling-large.jpg |
|---|
![]() |
Metadata
Metadata
Assignees
Labels
No labels


