Skip to content

Commit 8bf486f

Browse files
committed
ENH: Update Q_PROPERTIES with CONSTANT specifier for Qt best practices
For improved compliance and to address warnings, marked read-only Q_PROPERTIES as CONSTANT across multiple modules, ensuring adherence to modern Qt conventions.
1 parent c5c036d commit 8bf486f

30 files changed

+65
-65
lines changed

Libs/CommandLineModules/Testing/Cpp/ctkCmdLineModuleQtCustomizationTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ class MyImageComboBox : public QComboBox
7272

7373
Q_PROPERTY(QString currentLabel READ currentLabel WRITE setCurrentLabel)
7474
Q_PROPERTY(QString currentPath READ currentPath WRITE setCurrentPath)
75-
Q_PROPERTY(const MyImageData* currentImage READ currentImage)
75+
Q_PROPERTY(const MyImageData* currentImage READ currentImage CONSTANT)
7676

7777
MyImageComboBox(QWidget* parent = 0)
7878
: QComboBox(parent)

Libs/Core/ctkAbstractJob.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,19 +42,19 @@ class CTK_CORE_EXPORT ctkAbstractJob : public QObject
4242
{
4343
Q_OBJECT
4444
Q_PROPERTY(QString jobUID READ jobUID WRITE setJobUID);
45-
Q_PROPERTY(QString className READ className);
45+
Q_PROPERTY(QString className READ className CONSTANT);
4646
Q_PROPERTY(JobStatus status READ status WRITE setStatus);
4747
Q_PROPERTY(bool persistent READ isPersistent WRITE setIsPersistent);
4848
Q_PROPERTY(bool retryCounter READ retryCounter WRITE setRetryCounter);
4949
Q_PROPERTY(int maximumNumberOfRetry READ maximumNumberOfRetry WRITE setMaximumNumberOfRetry);
5050
Q_PROPERTY(int retryDelay READ retryDelay WRITE setRetryDelay);
5151
Q_PROPERTY(bool maximumConcurrentJobsPerType READ maximumConcurrentJobsPerType WRITE setMaximumConcurrentJobsPerType);
5252
Q_PROPERTY(QThread::Priority priority READ priority WRITE setPriority);
53-
Q_PROPERTY(QDateTime creationDateTime READ creationDateTime);
54-
Q_PROPERTY(QDateTime startDateTime READ startDateTime);
55-
Q_PROPERTY(QDateTime completionDateTime READ completionDateTime);
53+
Q_PROPERTY(QDateTime creationDateTime READ creationDateTime CONSTANT);
54+
Q_PROPERTY(QDateTime startDateTime READ startDateTime CONSTANT);
55+
Q_PROPERTY(QDateTime completionDateTime READ completionDateTime CONSTANT);
5656
Q_PROPERTY(QString runningThreadID READ runningThreadID WRITE setRunningThreadID);
57-
Q_PROPERTY(QString log READ log);
57+
Q_PROPERTY(QString log READ log CONSTANT);
5858
Q_PROPERTY(bool destroyAfterUse READ destroyAfterUse WRITE setDestroyAfterUse);
5959

6060
public:

Libs/Core/ctkBooleanMapper.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class CTK_CORE_EXPORT ctkBooleanMapper : public QObject
5252
{
5353
Q_OBJECT
5454
/// This property contains the name of the object mapped property.
55-
Q_PROPERTY(QByteArray propertyName READ propertyName)
55+
Q_PROPERTY(QByteArray propertyName READ propertyName CONSTANT)
5656

5757
/// This property holds the mapped property.
5858
/// It is the value of the mapped object property

Libs/Core/ctkCommandLineParser.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,9 @@ class QSettings;
6262
class CTK_CORE_EXPORT ctkCommandLineParser : public QObject
6363
{
6464
Q_OBJECT
65-
Q_PROPERTY(QString errorString READ errorString)
66-
Q_PROPERTY(QStringList unparsedArguments READ unparsedArguments)
67-
Q_PROPERTY(bool settingsEnabled READ settingsEnabled)
65+
Q_PROPERTY(QString errorString READ errorString CONSTANT)
66+
Q_PROPERTY(QStringList unparsedArguments READ unparsedArguments CONSTANT)
67+
Q_PROPERTY(bool settingsEnabled READ settingsEnabled CONSTANT)
6868

6969
public:
7070

Libs/Core/ctkErrorLogAbstractModel.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class CTK_CORE_EXPORT ctkErrorLogAbstractModel : public QSortFilterProxyModel
4747
Q_PROPERTY(int numberOfFilesToKeep READ numberOfFilesToKeep WRITE setNumberOfFilesToKeep)
4848
Q_PROPERTY(bool fileLoggingEnabled READ fileLoggingEnabled WRITE setFileLoggingEnabled)
4949
Q_PROPERTY(QString fileLoggingPattern READ fileLoggingPattern WRITE setFileLoggingPattern)
50-
Q_PROPERTY(QStringList msgHandlerNames READ msgHandlerNames)
50+
Q_PROPERTY(QStringList msgHandlerNames READ msgHandlerNames CONSTANT)
5151

5252
public:
5353
typedef QSortFilterProxyModel Superclass;

Libs/Core/ctkJobScheduler.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@ class ctkJobSchedulerPrivate; //Forward declaration needed within this file
4646
class CTK_CORE_EXPORT ctkJobScheduler : public QObject
4747
{
4848
Q_OBJECT
49-
Q_PROPERTY(int numberOfJobs READ numberOfJobs);
50-
Q_PROPERTY(int numberOfPersistentJobs READ numberOfPersistentJobs);
51-
Q_PROPERTY(int numberOfRunningJobs READ numberOfRunningJobs);
49+
Q_PROPERTY(int numberOfJobs READ numberOfJobs CONSTANT);
50+
Q_PROPERTY(int numberOfPersistentJobs READ numberOfPersistentJobs CONSTANT);
51+
Q_PROPERTY(int numberOfRunningJobs READ numberOfRunningJobs CONSTANT);
5252
Q_PROPERTY(int freezeJobsScheduling READ freezeJobsScheduling WRITE setFreezeJobsScheduling);
5353
Q_PROPERTY(int maximumThreadCount READ maximumThreadCount WRITE setMaximumThreadCount);
5454
Q_PROPERTY(int maximumNumberOfRetry READ maximumNumberOfRetry WRITE setMaximumNumberOfRetry);

Libs/DICOM/Core/ctkDICOMIndexer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class CTK_DICOM_CORE_EXPORT ctkDICOMIndexer : public QObject
3939
Q_OBJECT
4040
Q_PROPERTY(bool backgroundImportEnabled READ isBackgroundImportEnabled WRITE setBackgroundImportEnabled)
4141
Q_PROPERTY(bool followSymlinks READ followSymlinks WRITE setFollowSymlinks)
42-
Q_PROPERTY(bool importing READ isImporting)
42+
Q_PROPERTY(bool importing READ isImporting CONSTANT)
4343

4444
public:
4545
explicit ctkDICOMIndexer(QObject *parent = 0);

Libs/DICOM/Core/ctkDICOMQuery.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class CTK_DICOM_CORE_EXPORT ctkDICOMQuery : public QObject
4646
Q_PROPERTY(int port READ port WRITE setPort);
4747
Q_PROPERTY(int connectionTimeout READ connectionTimeout WRITE setConnectionTimeout);
4848
Q_PROPERTY(int maximumPatientsQuery READ maximumPatientsQuery WRITE setMaximumPatientsQuery);
49-
Q_PROPERTY(QList<QPair<QString,QString>> studyAndSeriesInstanceUIDQueried READ studyAndSeriesInstanceUIDQueried);
49+
Q_PROPERTY(QList<QPair<QString,QString>> studyAndSeriesInstanceUIDQueried READ studyAndSeriesInstanceUIDQueried CONSTANT);
5050
Q_PROPERTY(QString jobUID READ jobUID WRITE setJobUID);
5151

5252
public:

Libs/DICOM/Core/ctkDICOMRetrieve.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ class CTK_DICOM_CORE_EXPORT ctkDICOMRetrieve : public QObject
4848
Q_PROPERTY(QString moveDestinationAETitle READ moveDestinationAETitle WRITE setMoveDestinationAETitle);
4949
Q_PROPERTY(bool keepAssociationOpen READ keepAssociationOpen WRITE setKeepAssociationOpen);
5050
Q_PROPERTY(int connectionTimeout READ connectionTimeout WRITE setConnectionTimeout);
51-
Q_PROPERTY(QString seriesInstanceUID READ seriesInstanceUID);
52-
Q_PROPERTY(QString studyInstanceUID READ studyInstanceUID);
51+
Q_PROPERTY(QString seriesInstanceUID READ seriesInstanceUID CONSTANT);
52+
Q_PROPERTY(QString studyInstanceUID READ studyInstanceUID CONSTANT);
5353
Q_PROPERTY(QString jobUID READ jobUID WRITE setJobUID);
5454

5555
public:

Libs/DICOM/Widgets/ctkDICOMAppWidget.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class ctkDICOMDatabase;
3535
class CTK_DICOM_WIDGETS_EXPORT ctkDICOMAppWidget : public QWidget
3636
{
3737
Q_OBJECT
38-
Q_PROPERTY(ctkDICOMDatabase* database READ database)
38+
Q_PROPERTY(ctkDICOMDatabase* database READ database CONSTANT)
3939
Q_PROPERTY(QString databaseDirectory READ databaseDirectory WRITE setDatabaseDirectory)
4040
Q_PROPERTY(bool searchWidgetPopUpMode READ searchWidgetPopUpMode WRITE setSearchWidgetPopUpMode)
4141
Q_PROPERTY(QStringList tagsToPrecache READ tagsToPrecache WRITE setTagsToPrecache)

0 commit comments

Comments
 (0)