Skip to content

Commit 5275753

Browse files
Seancompwright
authored andcommitted
Use event.clientX instead of just event.x, a property that doesn't exist on some browsers
Fixes #62 See https://developer.mozilla.org/en/docs/Web/Events/click
1 parent 8c4b312 commit 5275753

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

chartjs-plugin-zoom.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -330,8 +330,8 @@ var zoomPlugin = {
330330
var yAxis = getYAxis(chartInstance);
331331
var beginPoint = chartInstance.zoom._dragZoomStart;
332332
var offsetX = beginPoint.target.getBoundingClientRect().left;
333-
var startX = Math.min(beginPoint.x, event.x) - offsetX;
334-
var endX = Math.max(beginPoint.x, event.x) - offsetX;
333+
var startX = Math.min(beginPoint.clientX, event.clientX) - offsetX;
334+
var endX = Math.max(beginPoint.clientX, event.clientX) - offsetX;
335335
var dragDistance = endX - startX;
336336
var chartDistance = chartArea.right - chartArea.left;
337337
var zoom = 1 + ((chartDistance - dragDistance) / chartDistance );
@@ -446,8 +446,8 @@ var zoomPlugin = {
446446
var beginPoint = chartInstance.zoom._dragZoomStart;
447447
var endPoint = chartInstance.zoom._dragZoomEnd;
448448
var offsetX = beginPoint.target.getBoundingClientRect().left;
449-
var startX = Math.min(beginPoint.x, endPoint.x) - offsetX;
450-
var endX = Math.max(beginPoint.x, endPoint.x) - offsetX;
449+
var startX = Math.min(beginPoint.clientX, endPoint.clientX) - offsetX;
450+
var endX = Math.max(beginPoint.clientX, endPoint.clientX) - offsetX;
451451
var rectWidth = endX - startX;
452452

453453

chartjs-plugin-zoom.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/chart.zoom.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -318,8 +318,8 @@ var zoomPlugin = {
318318
var yAxis = getYAxis(chartInstance);
319319
var beginPoint = chartInstance.zoom._dragZoomStart;
320320
var offsetX = beginPoint.target.getBoundingClientRect().left;
321-
var startX = Math.min(beginPoint.x, event.x) - offsetX;
322-
var endX = Math.max(beginPoint.x, event.x) - offsetX;
321+
var startX = Math.min(beginPoint.clientX, event.clientX) - offsetX;
322+
var endX = Math.max(beginPoint.clientX, event.clientX) - offsetX;
323323
var dragDistance = endX - startX;
324324
var chartDistance = chartArea.right - chartArea.left;
325325
var zoom = 1 + ((chartDistance - dragDistance) / chartDistance );
@@ -434,8 +434,8 @@ var zoomPlugin = {
434434
var beginPoint = chartInstance.zoom._dragZoomStart;
435435
var endPoint = chartInstance.zoom._dragZoomEnd;
436436
var offsetX = beginPoint.target.getBoundingClientRect().left;
437-
var startX = Math.min(beginPoint.x, endPoint.x) - offsetX;
438-
var endX = Math.max(beginPoint.x, endPoint.x) - offsetX;
437+
var startX = Math.min(beginPoint.clientX, endPoint.clientX) - offsetX;
438+
var endX = Math.max(beginPoint.clientX, endPoint.clientX) - offsetX;
439439
var rectWidth = endX - startX;
440440

441441

0 commit comments

Comments
 (0)