Fix animations in web workers #12158
Open
+2
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change you can enable animations in web workers without getting an error and it removes the disable animation override when using the basic platform, so that you don't need to provide a custom platform to use animations.
This PR replaces requestAnimFrame with
requestAnimationFrame, the current function will cause aMaximum call stack size exceedederror if the window is undefined and_runningistruein this function, so it should be safe to just userequestAnimationFrame. The other use of the requestAnimFrame function does not cause an error if the window is undefined but i think we can also replace it.