Skip to content

Commit a9e67d1

Browse files
committed
fix: filegroup circular deps
Eliminate circular dependencies within package definitions. Bazel dependency graph rely on DAG (Directed Acyclic Graph). Provided sources (`srcs`) to the target are already all transitive package dependencies taken from the lockfile, thus its `:data` is sufficient to fully cover package and all its dependencies. Taking above and current implementation, all package deps should be listed with `:data`. E.g. for `libgcc-s1/amd64:amd64` package, it is: ```bzl filegroup( name = "amd64", srcs = [ "//libc6/amd64:data", "//gcc-12-base/amd64:data", ] + [":data"], visibility = ["//visibility:public"], ) ``` is equal
1 parent 7c615ee commit a9e67d1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

apt/private/deb_translate_lock.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ def _deb_translate_lock_impl(rctx):
192192
control_targets = '"@%s//:control"' % repo_name,
193193
src = '"@%s//:data"' % repo_name,
194194
deps = starlark_codegen_utils.to_list_attr([
195-
"//%s/%s" % (dep["name"], package["arch"])
195+
"//%s/%s:data" % (dep["name"], package["arch"])
196196
for dep in package["dependencies"]
197197
]),
198198
urls = package["urls"],

0 commit comments

Comments
 (0)