Commit a9e67d1
committed
fix: filegroup circular deps
Eliminate circular dependencies within package definitions.
Bazel dependency graph rely on DAG (Directed Acyclic Graph).
Provided sources (`srcs`) to the target are already all transitive
package dependencies taken from the lockfile, thus its `:data`
is sufficient to fully cover package and all its dependencies.
Taking above and current implementation, all package deps should be
listed with `:data`. E.g. for `libgcc-s1/amd64:amd64` package, it is:
```bzl
filegroup(
name = "amd64",
srcs = [
"//libc6/amd64:data",
"//gcc-12-base/amd64:data",
] + [":data"],
visibility = ["//visibility:public"],
)
```
is equal1 parent 7c615ee commit a9e67d1
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
192 | 192 | | |
193 | 193 | | |
194 | 194 | | |
195 | | - | |
| 195 | + | |
196 | 196 | | |
197 | 197 | | |
198 | 198 | | |
| |||
0 commit comments