-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(bedrock-agentcore-alpha): use static construct ID for asset-based runtime artifacts #36241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
0ba7adb to
c1c58aa
Compare
… runtime artifacts
c1c58aa to
d0a4b5a
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #35968
Reason for this change
Using
AgentRuntimeArtifact.fromAsset()adds an MD5 hash of the directory path to the construct ID, causing CDK pipelines to self-mutate whenever the Docker image directory contents change. This is inconsistent with how other Docker images handle assets.Description of changes
AssetImage.bind()and changed the construct ID fromAgentRuntimeArtifact${hash}to a staticAgentRuntimeArtifactDescribe any new or updated permissions being added
NA
Description of how you validated changes
Added unit tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license