Skip to content

Conversation

@alvazjor
Copy link
Contributor

Issue # (if applicable)

Closes #35968

Reason for this change

Using AgentRuntimeArtifact.fromAsset() adds an MD5 hash of the directory path to the construct ID, causing CDK pipelines to self-mutate whenever the Docker image directory contents change. This is inconsistent with how other Docker images handle assets.

Description of changes

  • Removed the md5hash import and usage from AssetImage.bind() and changed the construct ID from AgentRuntimeArtifact${hash} to a static AgentRuntimeArtifact
  • Added unit tests to verify the static ID behavior
  • Fixed existing test paths to use path.join(__dirname, ...) for portability

Describe any new or updated permissions being added

NA

Description of how you validated changes

Added unit tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 28, 2025 18:12
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 labels Nov 28, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 28, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@alvazjor alvazjor added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Nov 28, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 28, 2025 18:19

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 28, 2025
@alvazjor alvazjor force-pushed the fix/bedrock-agentcore-asset-image-hash branch from 0ba7adb to c1c58aa Compare December 1, 2025 08:44
@alvazjor alvazjor force-pushed the fix/bedrock-agentcore-asset-image-hash branch from c1c58aa to d0a4b5a Compare December 1, 2025 08:47
@Abogical Abogical self-assigned this Dec 1, 2025
@mergify
Copy link
Contributor

mergify bot commented Dec 2, 2025

Merge Queue Status Beta

✅ The pull request has been merged

This pull request spent 30 minutes 7 seconds in the queue, including 29 minutes 58 seconds running CI.
The checks were run in-place.

Required conditions to merge

@mergify
Copy link
Contributor

mergify bot commented Dec 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Dec 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e2bdddd into main Dec 2, 2025
19 of 20 checks passed
@mergify mergify bot deleted the fix/bedrock-agentcore-asset-image-hash branch December 2, 2025 17:03
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(bedrock-agentcore-alpha): image asset based runtime artifacts cause pipeline self-mutation

3 participants