Skip to content

Refactor GC and GC tests to be more reliable #2645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Refactor GC and GC tests to be more reliable #2645

wants to merge 1 commit into from
+93 −72

Conversation

@tstirrat15
Copy link
Contributor

@tstirrat15 tstirrat15 commented Oct 23, 2025 •
edited
Loading

Parting out #2455

Description

Part of getting the testifyrequire linter enabled.

TODO

Changes

Will annotate.

Testing

Review

@tstirrat15 tstirrat15 requested a review from a team as a code owner October 23, 2025 17:02
@tstirrat15 tstirrat15 marked this pull request as draft October 23, 2025 17:04
@tstirrat15 tstirrat15 changed the title Lint Fixes Part 9 Refactor GC and GC tests to be more reliable Oct 23, 2025
@github-actions github-actions bot added area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Oct 23, 2025
@codecov
Copy link

codecov bot commented Oct 23, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.45%. Comparing base (2f85876) to head (fc942de).

Files with missing lines Patch % Lines
pkg/cmd/datastore.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2645      +/-   ##
==========================================
- Coverage   79.48%   79.45%   -0.03%     
==========================================
  Files         456      456              
  Lines       47322    47322              
==========================================
- Hits        37609    37594      -15     
- Misses       6953     6964      +11     
- Partials     2760     2764       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the area/dependencies Affects dependencies label Oct 29, 2025
@github-actions github-actions bot added area/cli Affects the command line and removed area/dependencies Affects dependencies labels Nov 12, 2025
@James9074 @tstirrat15
chore: go-require: require must only be used in the goroutine running…
fc942de 
… the test function (testifylint) - Move require.Error outside of goroutine
@github-actions github-actions bot added the area/dependencies Affects dependencies label Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/cli Affects the command line area/datastore Affects the storage system area/dependencies Affects dependencies area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tstirrat15 @James9074