➡️ Migrate all language packages #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make atom-community#386 reviewable, that pr will be separated into many simpler prs. This is one of them. This first commit does the following: - update package.json - update package-lock.json using `./script/build` which also seems to update `apm/package-lock.json` - update packages/README.md - clone all language packages. Specifically: - `mkdir packages/language-<all of them>` - `cd packages/about` - For all languages: - `cd ../language-<>` - `git clone language-<>` - Move all files except `.git` from `language-<>/language-<>` to `language-<>` - delete `language-<>/language-<>` Since at first I accidentally updated `dependencies` then `packageDependencies`, it appears that since the versions of language-c, language-css, language-go, language-javascript, and language-sass don't match, `dependencies` was reset for those versions. [Those repos just happen to be precisely the ones that have tree-sitter v19](https://github.com/icecream17/atom-update-backlog/blob/main/Languages.md), (sans language-sass), which [currently breaks atom](atom#22129). So even though their repos are now in `packages`, **I've decided to not use them**. This is done by updating `packageDependencies` only for non-breaking languages.
aminya
requested changes
Jun 25, 2022
Member
|
Are the test failures relevant to these changes? |
Merged
Member
|
Maybe add waitsForPromise(() => atom.packages.activatePackage(path.join(__dirname, 'fixtures', 'package-with-snippets')));for fixing CI. |
Member
|
Or it could be atom/snippets@2de9091 I guess it's just some sort of flaky test; I wonder happens if you try my suggestion |
Member
|
We can't add this here. I forked the repository. @ThatXliner do you want to try your fix? |
aminya
approved these changes
Jun 30, 2022
Member
aminya
left a comment
aminya
left a comment
There was a problem hiding this comment.
I will merge this regardless of the tests because they seem unrelated. Since this is not merging to master, it is fine.
This was referenced Jul 1, 2022
icecream17
pushed a commit
to icecream17/atom
that referenced
this pull request
Jul 3, 2022
... previously v19 tree-sitter language packages. Continuation of atom-community#399 (atom-community@477b075) but where the packages that would've broke Atom are now updated Another link: atom-community#403 (comment)
icecream17
pushed a commit
that referenced
this pull request
Jul 3, 2022
... previously v19 tree-sitter language packages. Continuation of #399 (477b075) but where the packages that would've broke Atom are now updated Another link: #403 (comment)
aminya
pushed a commit
that referenced
this pull request
Jul 3, 2022
... previously v19 tree-sitter language packages. Continuation of #399 (477b075) but where the packages that would've broke Atom are now updated Another link: #403 (comment)
aminya
pushed a commit
that referenced
this pull request
Jul 9, 2022
... previously v19 tree-sitter language packages. Continuation of #399 (477b075) but where the packages that would've broke Atom are now updated Another link: #403 (comment)
aminya
pushed a commit
that referenced
this pull request
Jul 9, 2022
... previously v19 tree-sitter language packages. Continuation of #399 (477b075) but where the packages that would've broke Atom are now updated Another link: #403 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make #386 reviewable, that pr will be separated into many simpler prs. This is one of them.
The first commit does the following:
./script/buildwhich also seems to updateapm/package-lock.jsonI've added these repos to
packagesbut I'm not actually updating the package.json for these packages:Consequently they're unused. See the first commit for an explanation, but basically they're at tree-sitter v19 which currently breaks atom.
Possible changes
A second commit or rebase could take care of these issues:
This would've/will be so useful:
This saves the commit history of the language-packages:
#386 (comment)
https://discord.com/channels/737254137690980372/809982257468801065/988156409977917510