Skip to content

Conversation

@rohan-b99
Copy link
Contributor

@rohan-b99 rohan-b99 commented Nov 25, 2025

Adds validation for propagator configuration, ensuring that a warning log is emitted if:

  • The datadog propagator is enabled, and any other propagators are enabled (except baggage)
  • Datadog tracing is enabled and other propagators are enabled (except for baggage)

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@rohan-b99 rohan-b99 requested review from a team as code owners November 25, 2025 17:06
@apollo-librarian
Copy link

apollo-librarian bot commented Nov 25, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed
* graphos/routing/(latest)/observability/router-telemetry-otel/telemetry-pipelines/trace-exporters/overview.mdx

Build ID: 8c937f2bd8b75739da453cde
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/8c937f2bd8b75739da453cde

@rohan-b99 rohan-b99 changed the title Rohan b99/datadog propagator must be exclusively active 2 Rohan b99/datadog propagator should be exclusively active (warn if not) Nov 25, 2025
Copy link
Contributor

@aaronArinder aaronArinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rohan-b99 rohan-b99 enabled auto-merge (squash) December 2, 2025 12:01
@rohan-b99 rohan-b99 merged commit b890c1e into dev Dec 2, 2025
15 checks passed
@rohan-b99 rohan-b99 deleted the rohan-b99/datadog-propagator-must-be-exclusively-active-2 branch December 2, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants