Skip to content

Conversation

@a7med3del1973
Copy link
Contributor

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

Copy link
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please elaborate how it improves the changes in the Trial Balance Processing ? Any financial user has sent a report about an issue with this feature?

@a7med3del1973
Copy link
Contributor Author

Could you please elaborate how it improves the changes in the Trial Balance Processing ? Any financial user has sent a report about an issue with this feature?

There's no user reported issues the matter related with maintained code is more readable, focused methods and consolidating duplicated logic

@adamsaghy
Copy link
Contributor

@a7med3del1973 FINERACT-2181 is closed story. Please kindly use FINERACT-2326 instead.

Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly see my request.

@a7med3del1973 a7med3del1973 changed the title FINERACT-2181: Refactor trial balance processing to reduce cognitive complexity FINERACT-2236: Refactor trial balance processing to reduce cognitive complexity Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants