Skip to content

Conversation

@seawinde
Copy link
Contributor

@seawinde seawinde commented Nov 26, 2025

What problem does this PR solve?

This PR addresses two issues:
1 it stabilizes the regression tests for topN_rewrite and limit_rewrite, and
2 it fixes a bug affecting negative test cases. For example, the following case should not be rewritten successfully but was incorrectly rewritten

         CREATE MATERIALIZED VIEW mv
        BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL
        DISTRIBUTED BY RANDOM BUCKETS 2
        PROPERTIES ('replication_num' = '1') 
        AS
            select
            o_orderdate,
            ps_partkey,
            l_orderkey
            from
            orders left
            join lineitem on l_orderkey = o_orderkey
            left join partsupp on ps_partkey = l_partkey and l_suppkey = ps_suppkey
            where o_orderdate > '2025-01-02'
            order by o_orderdate, l_orderkey, ps_partkey
            limit 8 offset 1;

the query as following should not rewrite successfully

            select
            o_orderdate,
            ps_partkey,
            l_orderkey
            from
            orders left
            join lineitem on l_orderkey = o_orderkey
            left join partsupp on ps_partkey = l_partkey and l_suppkey = ps_suppkey
            order by o_orderdate, l_orderkey
            limit 4 offset 2;

Issue Number: close #xxx

Related PR: #58018

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@seawinde
Copy link
Contributor Author

run buildall

1 similar comment
@seawinde
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34260 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5506df4227e302d9f74dfd324a1072d0d0bec971, data reload: false

------ Round 1 ----------------------------------
q1	17601	5074	4948	4948
q2	2068	315	204	204
q3	10224	1340	731	731
q4	10231	923	375	375
q5	7547	2290	2385	2290
q6	182	173	141	141
q7	902	796	632	632
q8	9346	1368	1159	1159
q9	6924	5297	5351	5297
q10	6870	2233	1809	1809
q11	489	301	283	283
q12	332	376	224	224
q13	17932	3644	3041	3041
q14	251	263	226	226
q15	617	528	511	511
q16	1037	1011	958	958
q17	596	858	354	354
q18	7299	7095	7150	7095
q19	1278	937	532	532
q20	340	338	224	224
q21	3686	2595	2271	2271
q22	1039	1023	955	955
Total cold run time: 106791 ms
Total hot run time: 34260 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4952	4922	4905	4905
q2	344	415	315	315
q3	2147	2680	2305	2305
q4	1391	1754	1289	1289
q5	4184	4316	4502	4316
q6	215	180	138	138
q7	2045	2002	1811	1811
q8	2676	2499	2471	2471
q9	7556	7572	7451	7451
q10	3145	3227	2832	2832
q11	586	506	500	500
q12	705	767	607	607
q13	3590	3917	3419	3419
q14	296	299	306	299
q15	565	522	509	509
q16	1097	1137	1079	1079
q17	1141	1520	1384	1384
q18	7876	7847	7526	7526
q19	792	839	919	839
q20	1940	1964	1812	1812
q21	4721	4355	4219	4219
q22	1097	1074	1013	1013
Total cold run time: 53061 ms
Total hot run time: 51039 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184119 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5506df4227e302d9f74dfd324a1072d0d0bec971, data reload: false

query1	1027	413	389	389
query2	6605	1596	1581	1581
query3	6755	221	233	221
query4	25587	23094	22318	22318
query5	4380	636	517	517
query6	364	245	224	224
query7	4639	502	308	308
query8	300	257	240	240
query9	8700	2532	2542	2532
query10	503	355	317	317
query11	15224	14824	14962	14824
query12	176	115	112	112
query13	1691	591	455	455
query14	10150	8939	8901	8901
query15	216	202	186	186
query16	7320	719	521	521
query17	1275	778	645	645
query18	2006	432	342	342
query19	213	214	182	182
query20	145	125	122	122
query21	222	138	114	114
query22	3920	4154	3908	3908
query23	32971	31819	32034	31819
query24	8462	2432	2380	2380
query25	630	555	482	482
query26	1231	274	169	169
query27	2751	509	352	352
query28	4386	2145	2119	2119
query29	872	635	520	520
query30	308	243	207	207
query31	831	708	637	637
query32	85	79	77	77
query33	610	395	331	331
query34	840	895	539	539
query35	810	845	788	788
query36	895	952	860	860
query37	122	106	85	85
query38	3362	3380	3246	3246
query39	1458	1410	1403	1403
query40	227	130	119	119
query41	65	66	62	62
query42	129	111	109	109
query43	439	473	412	412
query44	1262	757	752	752
query45	196	188	185	185
query46	892	1007	638	638
query47	1725	1703	1700	1700
query48	392	423	336	336
query49	751	481	411	411
query50	673	692	420	420
query51	3946	3955	3953	3953
query52	114	116	110	110
query53	249	277	194	194
query54	298	299	272	272
query55	95	91	93	91
query56	340	306	336	306
query57	1184	1184	1099	1099
query58	283	274	273	273
query59	2428	2541	2384	2384
query60	355	365	345	345
query61	203	151	161	151
query62	808	731	679	679
query63	222	187	200	187
query64	4601	1168	869	869
query65	4071	3975	3986	3975
query66	1181	434	341	341
query67	15109	14876	15030	14876
query68	8305	985	638	638
query69	521	336	317	317
query70	1314	1239	1187	1187
query71	468	332	311	311
query72	6087	4964	4886	4886
query73	636	585	349	349
query74	8540	8698	8356	8356
query75	4034	3356	2871	2871
query76	3688	1143	714	714
query77	816	399	309	309
query78	9407	9745	9011	9011
query79	2077	868	607	607
query80	661	566	493	493
query81	483	273	236	236
query82	426	167	140	140
query83	266	269	251	251
query84	254	116	100	100
query85	907	482	442	442
query86	344	292	276	276
query87	3758	3571	3399	3399
query88	3374	2248	2233	2233
query89	390	327	290	290
query90	1950	249	223	223
query91	181	175	146	146
query92	75	72	62	62
query93	1413	1019	663	663
query94	732	441	330	330
query95	511	397	402	397
query96	503	572	274	274
query97	2916	2967	2890	2890
query98	241	217	219	217
query99	1386	1376	1279	1279
Total cold run time: 270944 ms
Total hot run time: 184119 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.37 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5506df4227e302d9f74dfd324a1072d0d0bec971, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.04	0.05
query3	0.26	0.09	0.09
query4	1.60	0.11	0.11
query5	0.26	0.25	0.26
query6	1.18	0.65	0.65
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.59	0.54	0.51
query10	0.57	0.58	0.57
query11	0.16	0.11	0.11
query12	0.16	0.12	0.12
query13	0.63	0.62	0.61
query14	1.01	1.00	1.00
query15	0.87	0.83	0.82
query16	0.40	0.38	0.40
query17	1.00	1.06	1.02
query18	0.22	0.19	0.20
query19	1.90	1.84	1.79
query20	0.01	0.02	0.01
query21	15.43	0.18	0.14
query22	5.10	0.07	0.05
query23	15.67	0.26	0.10
query24	2.86	0.85	0.35
query25	0.08	0.06	0.07
query26	0.14	0.13	0.13
query27	0.07	0.06	0.05
query28	4.53	1.15	0.92
query29	12.62	3.88	3.21
query30	0.27	0.14	0.11
query31	2.82	0.59	0.38
query32	3.23	0.56	0.47
query33	3.00	3.04	3.07
query34	15.73	5.22	4.58
query35	4.60	4.55	4.58
query36	0.68	0.50	0.49
query37	0.10	0.07	0.06
query38	0.07	0.04	0.04
query39	0.03	0.03	0.03
query40	0.17	0.14	0.13
query41	0.08	0.03	0.04
query42	0.05	0.03	0.02
query43	0.04	0.04	0.04
Total cold run time: 98.42 s
Total hot run time: 27.37 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 29.03% (9/31) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 45.16% (14/31) 🎉
Increment coverage report
Complete coverage report

@seawinde seawinde force-pushed the fix_top_n_rewrite_fail_when_query_mv_is_diff branch from 5506df4 to 882f7ed Compare November 27, 2025 03:42
@seawinde
Copy link
Contributor Author

run buildall

1 similar comment
@seawinde
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 26.47% (9/34) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

TPC-H: Total hot run time: 34458 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 52e843830ae293a764a5b2fa3d3151d12c6960de, data reload: false

------ Round 1 ----------------------------------
q1	17657	5085	4918	4918
q2	2053	307	215	215
q3	10230	1322	723	723
q4	10235	946	386	386
q5	7508	2398	2331	2331
q6	187	169	137	137
q7	934	774	629	629
q8	9338	1346	1134	1134
q9	7213	5409	5344	5344
q10	6869	2241	1845	1845
q11	497	297	270	270
q12	340	368	224	224
q13	17796	3707	3183	3183
q14	225	240	211	211
q15	600	533	525	525
q16	1019	1003	975	975
q17	597	869	367	367
q18	7380	7247	7011	7011
q19	1082	975	539	539
q20	347	345	228	228
q21	3733	3167	2310	2310
q22	1073	1021	953	953
Total cold run time: 106913 ms
Total hot run time: 34458 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4981	4962	4919	4919
q2	327	404	321	321
q3	2142	2714	2278	2278
q4	1341	1772	1361	1361
q5	4275	4512	4621	4512
q6	221	178	133	133
q7	2067	2037	1829	1829
q8	2651	2650	2625	2625
q9	7491	7569	7453	7453
q10	3057	3295	2830	2830
q11	626	527	526	526
q12	708	767	621	621
q13	3532	4036	3340	3340
q14	323	301	287	287
q15	560	534	517	517
q16	1110	1116	1092	1092
q17	1199	1596	1416	1416
q18	7843	7725	7633	7633
q19	858	848	885	848
q20	2042	2075	1976	1976
q21	4965	4337	4322	4322
q22	1091	1044	1004	1004
Total cold run time: 53410 ms
Total hot run time: 51843 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184397 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 52e843830ae293a764a5b2fa3d3151d12c6960de, data reload: false

query1	1033	434	394	394
query2	6550	1618	1587	1587
query3	6750	223	234	223
query4	25898	22921	22351	22351
query5	4412	617	499	499
query6	354	243	222	222
query7	4656	516	305	305
query8	293	267	251	251
query9	8723	2568	2587	2568
query10	528	341	323	323
query11	15317	14747	14744	14744
query12	172	117	112	112
query13	1694	587	470	470
query14	10160	8976	9078	8976
query15	216	208	197	197
query16	7175	714	458	458
query17	1010	772	633	633
query18	2020	436	355	355
query19	220	207	191	191
query20	135	126	124	124
query21	220	138	119	119
query22	3883	3938	4014	3938
query23	32955	32178	32445	32178
query24	8473	2400	2447	2400
query25	618	528	445	445
query26	1258	276	166	166
query27	2754	500	343	343
query28	4387	2141	2134	2134
query29	839	622	489	489
query30	307	237	209	209
query31	827	710	636	636
query32	82	72	73	72
query33	597	369	332	332
query34	800	866	531	531
query35	796	841	732	732
query36	887	954	877	877
query37	117	113	87	87
query38	3375	3361	3289	3289
query39	1490	1609	1408	1408
query40	227	128	124	124
query41	107	64	63	63
query42	129	113	114	113
query43	453	475	431	431
query44	1259	762	756	756
query45	200	190	182	182
query46	881	999	644	644
query47	1688	1737	1650	1650
query48	397	433	320	320
query49	791	494	420	420
query50	649	675	405	405
query51	3955	3915	3909	3909
query52	114	108	100	100
query53	242	263	193	193
query54	307	304	275	275
query55	92	93	93	93
query56	327	316	330	316
query57	1160	1184	1097	1097
query58	289	271	278	271
query59	2418	2483	2306	2306
query60	385	341	340	340
query61	167	161	167	161
query62	794	742	675	675
query63	223	190	193	190
query64	4601	1195	895	895
query65	4110	3972	3963	3963
query66	1167	439	334	334
query67	15429	14929	14767	14767
query68	8063	899	633	633
query69	521	329	309	309
query70	1269	1226	1255	1226
query71	462	335	312	312
query72	6056	4968	4982	4968
query73	654	584	355	355
query74	8684	8791	8495	8495
query75	3305	3325	2817	2817
query76	3386	1125	721	721
query77	531	401	313	313
query78	9508	9715	8833	8833
query79	1790	851	599	599
query80	638	588	518	518
query81	512	268	243	243
query82	212	159	132	132
query83	266	263	254	254
query84	311	114	95	95
query85	875	499	445	445
query86	382	313	293	293
query87	3517	3529	3450	3450
query88	3424	2300	2275	2275
query89	391	334	292	292
query90	2007	225	218	218
query91	169	170	142	142
query92	83	69	66	66
query93	1796	1012	659	659
query94	720	451	343	343
query95	497	416	397	397
query96	510	565	283	283
query97	2870	3006	2851	2851
query98	231	212	208	208
query99	1312	1411	1291	1291
Total cold run time: 269494 ms
Total hot run time: 184397 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.67 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 52e843830ae293a764a5b2fa3d3151d12c6960de, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.06	0.05
query3	0.26	0.08	0.08
query4	1.62	0.12	0.12
query5	0.27	0.27	0.25
query6	1.17	0.65	0.64
query7	0.04	0.03	0.03
query8	0.05	0.04	0.05
query9	0.60	0.54	0.52
query10	0.57	0.58	0.57
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.62	0.60
query14	1.01	1.00	1.00
query15	0.86	0.83	0.83
query16	0.41	0.40	0.39
query17	1.01	1.04	1.03
query18	0.21	0.20	0.21
query19	1.86	1.86	1.77
query20	0.02	0.01	0.01
query21	15.45	0.21	0.14
query22	5.00	0.06	0.04
query23	15.68	0.27	0.11
query24	2.15	0.71	0.62
query25	0.06	0.05	0.07
query26	0.15	0.13	0.14
query27	0.06	0.06	0.06
query28	4.77	1.13	0.92
query29	12.61	3.89	3.21
query30	0.28	0.13	0.12
query31	2.83	0.58	0.40
query32	3.22	0.55	0.48
query33	3.09	3.01	3.09
query34	15.88	5.19	4.58
query35	4.65	4.57	4.54
query36	0.67	0.51	0.49
query37	0.09	0.06	0.07
query38	0.06	0.04	0.03
query39	0.03	0.04	0.04
query40	0.18	0.14	0.14
query41	0.08	0.03	0.02
query42	0.04	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 98.12 s
Total hot run time: 27.67 s

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 29.41% (10/34) 🎉
Increment coverage report
Complete coverage report

@seawinde seawinde force-pushed the fix_top_n_rewrite_fail_when_query_mv_is_diff branch from 52e8438 to 052067b Compare December 1, 2025 07:51
@seawinde
Copy link
Contributor Author

seawinde commented Dec 1, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33750 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 052067bdb05b6aa6a9ffd9f84c540c41b198d7bd, data reload: false

------ Round 1 ----------------------------------
q1	17601	5073	4942	4942
q2	2043	319	206	206
q3	10256	1324	740	740
q4	10235	923	316	316
q5	7569	2396	2144	2144
q6	188	175	136	136
q7	961	781	653	653
q8	9349	1391	976	976
q9	7115	5370	5337	5337
q10	6846	2219	1745	1745
q11	532	312	281	281
q12	359	367	221	221
q13	17813	3648	3004	3004
q14	231	237	213	213
q15	581	515	509	509
q16	875	850	807	807
q17	590	769	515	515
q18	7885	7025	6955	6955
q19	1088	944	580	580
q20	363	345	226	226
q21	3701	3215	2280	2280
q22	1031	964	973	964
Total cold run time: 107212 ms
Total hot run time: 33750 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4942	4952	4952	4952
q2	346	397	327	327
q3	2180	2681	2272	2272
q4	1327	1737	1306	1306
q5	4208	4413	4552	4413
q6	225	183	128	128
q7	2070	1995	1879	1879
q8	2711	2517	2486	2486
q9	7521	7592	7609	7592
q10	3097	3254	2877	2877
q11	582	511	502	502
q12	684	756	632	632
q13	3488	3932	3349	3349
q14	301	301	290	290
q15	557	536	506	506
q16	903	912	884	884
q17	1163	1542	1377	1377
q18	8038	7784	7524	7524
q19	829	788	763	763
q20	1936	2034	1842	1842
q21	4601	4233	4195	4195
q22	1075	1036	980	980
Total cold run time: 52784 ms
Total hot run time: 51076 ms

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 24.24% (8/33) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

TPC-DS: Total hot run time: 182009 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 052067bdb05b6aa6a9ffd9f84c540c41b198d7bd, data reload: false

query1	1080	411	404	404
query2	6606	1203	1183	1183
query3	6741	237	220	220
query4	25886	23029	22830	22830
query5	4444	644	488	488
query6	335	229	220	220
query7	4668	498	303	303
query8	305	254	236	236
query9	8704	2625	2648	2625
query10	508	360	304	304
query11	15485	14804	14536	14536
query12	177	115	114	114
query13	1690	551	434	434
query14	9429	6062	6024	6024
query15	220	196	184	184
query16	7731	703	537	537
query17	1265	774	657	657
query18	2032	421	326	326
query19	211	197	169	169
query20	129	127	121	121
query21	221	132	116	116
query22	3989	4076	4063	4063
query23	33141	32147	31965	31965
query24	8477	2455	2409	2409
query25	581	506	476	476
query26	1245	269	162	162
query27	2757	489	358	358
query28	4320	2153	2153	2153
query29	804	609	489	489
query30	301	235	214	214
query31	831	703	674	674
query32	90	76	73	73
query33	587	392	322	322
query34	825	885	545	545
query35	784	826	752	752
query36	899	947	843	843
query37	126	108	89	89
query38	3789	3802	3816	3802
query39	1481	1411	1407	1407
query40	224	130	119	119
query41	64	62	63	62
query42	126	116	114	114
query43	443	451	413	413
query44	1285	737	734	734
query45	201	197	192	192
query46	876	998	635	635
query47	1676	1740	1625	1625
query48	395	411	325	325
query49	787	466	438	438
query50	654	703	411	411
query51	3864	3907	3899	3899
query52	109	114	106	106
query53	228	258	192	192
query54	304	298	276	276
query55	95	92	98	92
query56	320	333	328	328
query57	1120	1180	1098	1098
query58	302	274	273	273
query59	2374	2382	2327	2327
query60	351	345	338	338
query61	160	157	177	157
query62	778	754	668	668
query63	228	192	194	192
query64	4488	1192	884	884
query65	4061	3999	3961	3961
query66	1112	444	326	326
query67	15197	14977	14737	14737
query68	4640	967	627	627
query69	502	340	314	314
query70	1098	1010	1025	1010
query71	423	343	329	329
query72	5797	5082	5224	5082
query73	693	598	348	348
query74	8890	8799	8678	8678
query75	3055	3067	2545	2545
query76	3323	1160	753	753
query77	527	424	332	332
query78	9571	9844	8943	8943
query79	1494	846	591	591
query80	1576	633	553	553
query81	554	275	245	245
query82	407	143	117	117
query83	334	260	250	250
query84	257	119	95	95
query85	920	505	452	452
query86	361	303	298	298
query87	4027	4029	3978	3978
query88	2956	2288	2295	2288
query89	385	334	299	299
query90	1761	225	211	211
query91	174	166	141	141
query92	72	74	65	65
query93	1201	1004	658	658
query94	731	446	332	332
query95	510	410	404	404
query96	522	539	288	288
query97	2639	2683	2570	2570
query98	241	220	215	215
query99	1288	1385	1249	1249
Total cold run time: 265645 ms
Total hot run time: 182009 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.86 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 052067bdb05b6aa6a9ffd9f84c540c41b198d7bd, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.05
query3	0.26	0.10	0.09
query4	1.60	0.11	0.11
query5	0.28	0.27	0.25
query6	1.17	0.65	0.63
query7	0.04	0.03	0.02
query8	0.06	0.04	0.04
query9	0.58	0.50	0.49
query10	0.56	0.54	0.56
query11	0.14	0.10	0.10
query12	0.15	0.11	0.11
query13	0.62	0.59	0.61
query14	1.00	0.97	0.98
query15	0.80	0.80	0.79
query16	0.39	0.40	0.40
query17	1.06	1.02	1.02
query18	0.23	0.21	0.22
query19	1.96	1.81	1.71
query20	0.02	0.02	0.01
query21	15.45	0.27	0.14
query22	4.79	0.05	0.04
query23	16.14	0.27	0.11
query24	1.22	0.95	0.94
query25	0.06	0.11	0.05
query26	0.13	0.14	0.15
query27	0.06	0.05	0.05
query28	4.60	1.21	1.03
query29	12.59	3.94	3.25
query30	0.28	0.13	0.13
query31	2.83	0.62	0.40
query32	3.24	0.54	0.47
query33	3.07	3.04	3.03
query34	16.85	5.18	4.58
query35	4.58	4.47	4.56
query36	0.65	0.50	0.49
query37	0.10	0.07	0.07
query38	0.07	0.04	0.03
query39	0.04	0.03	0.03
query40	0.17	0.15	0.14
query41	0.08	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 98.16 s
Total hot run time: 27.86 s

@seawinde seawinde force-pushed the fix_top_n_rewrite_fail_when_query_mv_is_diff branch from 052067b to 24a868b Compare December 1, 2025 10:02
@seawinde
Copy link
Contributor Author

seawinde commented Dec 1, 2025

run buildall

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 24.24% (8/33) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

TPC-H: Total hot run time: 33984 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 24a868b778f832cfbc65fef5f3508f2815037b1f, data reload: false

------ Round 1 ----------------------------------
q1	17622	5082	4904	4904
q2	2108	305	207	207
q3	10233	1296	738	738
q4	10230	862	342	342
q5	7552	2389	2105	2105
q6	191	173	142	142
q7	954	774	651	651
q8	9357	1318	1034	1034
q9	6918	5263	5354	5263
q10	6765	2199	1781	1781
q11	528	318	294	294
q12	340	373	232	232
q13	17780	3643	3033	3033
q14	235	243	219	219
q15	581	526	511	511
q16	871	866	805	805
q17	576	740	552	552
q18	7371	7222	6956	6956
q19	928	953	583	583
q20	353	353	233	233
q21	3533	3610	2439	2439
q22	1006	994	960	960
Total cold run time: 106032 ms
Total hot run time: 33984 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4911	4948	4889	4889
q2	353	392	319	319
q3	2166	2645	2338	2338
q4	1292	1764	1292	1292
q5	4198	4279	4682	4279
q6	211	176	130	130
q7	2009	1966	1844	1844
q8	2637	2516	2468	2468
q9	7490	7402	7574	7402
q10	2984	3299	2876	2876
q11	593	539	523	523
q12	686	750	810	750
q13	3437	3785	3438	3438
q14	277	294	303	294
q15	575	526	509	509
q16	912	937	894	894
q17	1158	1452	1483	1452
q18	7948	7677	7579	7579
q19	786	785	825	785
q20	2014	2141	1914	1914
q21	4861	4584	4405	4405
q22	1131	1104	1009	1009
Total cold run time: 52629 ms
Total hot run time: 51389 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 182274 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 24a868b778f832cfbc65fef5f3508f2815037b1f, data reload: false

query1	1031	403	435	403
query2	6600	1177	1201	1177
query3	6760	227	230	227
query4	25616	23491	22773	22773
query5	5061	664	493	493
query6	360	246	236	236
query7	4677	516	311	311
query8	309	263	262	262
query9	8728	2632	2667	2632
query10	553	363	324	324
query11	15202	14788	15061	14788
query12	192	123	117	117
query13	1699	587	447	447
query14	9890	6049	6057	6049
query15	219	209	193	193
query16	7692	700	520	520
query17	1236	778	675	675
query18	2075	442	349	349
query19	230	216	182	182
query20	140	132	123	123
query21	224	138	120	120
query22	3881	3955	3808	3808
query23	32917	32104	32068	32068
query24	8559	2428	2413	2413
query25	594	518	469	469
query26	1250	285	166	166
query27	2709	502	345	345
query28	4301	2175	2172	2172
query29	797	619	504	504
query30	316	238	215	215
query31	854	720	631	631
query32	81	74	79	74
query33	594	394	332	332
query34	813	882	564	564
query35	787	831	734	734
query36	875	926	831	831
query37	124	117	96	96
query38	3831	3817	3870	3817
query39	1478	1404	1385	1385
query40	231	135	123	123
query41	67	64	63	63
query42	123	122	111	111
query43	448	445	423	423
query44	1339	763	741	741
query45	203	195	186	186
query46	896	998	655	655
query47	1695	1754	1641	1641
query48	400	440	334	334
query49	764	482	434	434
query50	676	709	430	430
query51	3848	3894	3830	3830
query52	117	113	113	113
query53	243	262	193	193
query54	310	348	293	293
query55	102	99	97	97
query56	345	350	325	325
query57	1171	1165	1089	1089
query58	296	282	268	268
query59	2352	2406	2413	2406
query60	376	353	329	329
query61	158	160	164	160
query62	792	727	669	669
query63	236	198	202	198
query64	4613	1195	892	892
query65	4078	3971	3949	3949
query66	1098	439	333	333
query67	15062	15113	14808	14808
query68	5222	982	627	627
query69	522	356	315	315
query70	1122	1081	965	965
query71	439	352	311	311
query72	5820	4917	4846	4846
query73	654	574	344	344
query74	8907	8868	8648	8648
query75	3051	3038	2541	2541
query76	3326	1168	781	781
query77	500	445	335	335
query78	9432	9617	8896	8896
query79	1655	877	600	600
query80	1659	589	510	510
query81	555	272	245	245
query82	405	143	113	113
query83	369	264	242	242
query84	262	119	100	100
query85	926	490	448	448
query86	382	294	294	294
query87	4044	4059	4064	4059
query88	3040	2352	2314	2314
query89	394	340	302	302
query90	1745	242	234	234
query91	203	198	160	160
query92	90	81	67	67
query93	1150	1020	668	668
query94	763	477	363	363
query95	528	432	425	425
query96	531	559	291	291
query97	2605	2698	2591	2591
query98	246	218	218	218
query99	1288	1414	1303	1303
Total cold run time: 267129 ms
Total hot run time: 182274 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.3 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 24a868b778f832cfbc65fef5f3508f2815037b1f, data reload: false

query1	0.05	0.04	0.04
query2	0.10	0.05	0.05
query3	0.25	0.09	0.09
query4	1.60	0.12	0.11
query5	0.28	0.28	0.25
query6	1.18	0.65	0.63
query7	0.03	0.03	0.03
query8	0.06	0.04	0.04
query9	0.58	0.52	0.50
query10	0.57	0.56	0.56
query11	0.15	0.11	0.11
query12	0.16	0.12	0.12
query13	0.62	0.60	0.59
query14	0.99	1.00	0.97
query15	0.82	0.79	0.81
query16	0.39	0.42	0.39
query17	1.07	1.06	1.04
query18	0.23	0.22	0.21
query19	1.86	1.87	1.84
query20	0.02	0.01	0.01
query21	15.47	0.26	0.14
query22	4.90	0.05	0.05
query23	16.11	0.27	0.11
query24	1.70	0.25	0.72
query25	0.11	0.07	0.09
query26	0.14	0.14	0.13
query27	0.06	0.04	0.05
query28	5.11	1.21	1.03
query29	12.62	3.89	3.20
query30	0.27	0.14	0.11
query31	2.82	0.62	0.41
query32	3.23	0.57	0.47
query33	3.03	3.02	3.04
query34	16.71	5.21	4.51
query35	4.58	4.57	4.55
query36	0.66	0.51	0.50
query37	0.11	0.07	0.06
query38	0.08	0.04	0.04
query39	0.04	0.03	0.03
query40	0.16	0.13	0.13
query41	0.09	0.03	0.02
query42	0.04	0.03	0.03
query43	0.05	0.03	0.03
Total cold run time: 99.1 s
Total hot run time: 27.3 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.x p0_w reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants