add GHA CI configuration #30
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - 'master' | ||
| pull_request: | ||
| branches: | ||
| - 'master' | ||
|
|
||
| jobs: | ||
| test: | ||
| name: Test Suite | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| include: | ||
| - python: python3.6 | ||
| dist: ubuntu:bionic | ||
| - python: python3.8 | ||
| dist: ubuntu:focal | ||
| #- python: python3.10 | ||
| # dist: ubuntu:jammy | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Pull docker container | ||
| run: docker pull ${{ matrix.dist }} | ||
|
Owner
There was a problem hiding this comment. Is there really a good reason to use Docker manually at this point? If I remember correctly, that was mainly a Travis CI thing? Couldn't we just use Btw, to try those things out locally, there's act, in case you weren't aware of it yet.
Contributor
Author
There was a problem hiding this comment. Good question. As I just wrote in the other thread, I wanted to do the bare minimum of work to get CI green again. So this was the easiest thing to do. Feel free to simplify the setup in follow-up changes. :) |
||
| - name: Run test | ||
| run: docker run -v $PWD:/build/ -e PYTHON="${{ matrix.python }}" "${{ matrix.dist }}" /build/ci/run.sh | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error you had mentioned looks like this: mosquito/cysystemd#36
A comment there recommends doing
pip install cysystemdinstead, and indeed the PyPI page forsystemdactually links to thecysystemdrepository. So maybe changing that inrun.shwould make things work?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe? I'd say that is a separate change. My goal here is just to port the existing CI, not to improve/update the things we test. :) I had to change to newer Ubuntu releases since the old ones are no longer available or stopped working with recent pip packages, but I don't plan to do any more here than is necessary to maintain the old level of test coverage.