fix(Slider): precision when init #6183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RylanBot
requested review from
Cat1007,
PengYYYYY,
Wesley-0808,
chaishi,
liweijie0812,
uyarn,
zhangpaopao0609 and
zydemail
as code owners
Collaborator
TDesign Component Site Preview Open
|
commit: |
16 tasks
RylanBot
force-pushed
the
fix/slider/precision
branch
2 times, most recently
from
dd6d296 to
0bf0d73
Compare
RylanBot
force-pushed
the
fix/slider/precision
branch
from
0bf0d73 to
28e12ee
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a precision calculation issue in the Slider component during initialization. The main change involves moving utility functions to a common package and applying precision formatting when initializing slider values.
Key Changes:
- Extracted slider utility functions (
formatPrecision,formatSliderValue,getStopStyle,formatLabel) from local utils to@tdesign/common-js/slider/utils - Applied
formatPrecisionto initial value calculations in both range and single-value slider modes - Updated imports across slider-related files to use the centralized utilities
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/components/slider/utils/index.ts | Removed local utility functions (moved to common package) |
| packages/components/slider/slider.tsx | Applied precision formatting to initial values and updated imports |
| packages/components/slider/slider-button.tsx | Replaced manual precision formatting with formatPrecision utility |
| packages/components/slider/hooks/useSliderTooltip.tsx | Updated imports to use common utilities |
| packages/components/slider/hooks/useSliderMark.tsx | Updated imports to use common utilities |
| packages/components/slider/tests/base.test.tsx | Updated test imports to reference common utilities |
| packages/components/divider/tests/snapshots/divider.test.tsx.snap | Unrelated snapshot removal |
| packages/common | Subproject commit update to include new shared utilities |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/components/divider/__tests__/__snapshots__/divider.test.tsx.snap
Show resolved
Hide resolved
Collaborator
|
/update-common |
uyarn
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
截图来源：
demo -> swiper/card「原先」
「修复后」
📝 更新日志
tdesign-vue-next
@tdesign-vue-next/chat
@tdesign-vue-next/auto-import-resolver
☑️ 请求合并前的自查清单