Added plugin installation and uninstallation functionality to the PAGViewer application, added plugin version management and update checking capabilities. #3011

YyZz-wy · 2025-09-26T08:51:47Z

在PAGViewer中添加安装插件以及卸载插件功能

…t plugins

…ects installation paths and improve path sorting

… code clarity

…taller # Conflicts: # viewer/CMakeLists.txt

…After Effects

…ng command execution flow

Copilot

Pull Request Overview

This PR adds plugin installation and uninstallation functionality to the PAGViewer application. The implementation includes cross-platform support for Windows and macOS, with platform-specific installers that handle Adobe After Effects plugin management.

Key changes:

Added complete plugin installer infrastructure with platform-specific implementations
Integrated installation/uninstallation UI controls in the application menu
Added plugin version management and update checking capabilities

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
viewer/src/rendering/PAGView.cpp	Added flush call to render thread in else branch
viewer/src/platform/win/PluginInstaller.cpp	Windows-specific plugin installer implementation with registry scanning and privileged execution
viewer/src/platform/mac/PluginInstaller.mm	macOS-specific plugin installer using Objective-C APIs and AppleScript for privilege escalation
viewer/src/platform/PluginInstaller.h	Plugin installer interface defining common functionality across platforms
viewer/src/platform/PluginInstaller.cpp	Cross-platform plugin installer base implementation with version management
viewer/src/maintenance/PluginInstallerModel.h	Qt model wrapper for exposing plugin installer to QML
viewer/src/maintenance/PluginInstallerModel.cpp	Implementation of Qt model wrapper with signal forwarding
viewer/src/main.cpp	Registered new QML types and added missing include
viewer/assets/qml/Menu.qml	Added install/uninstall plugin menu items
viewer/assets/qml/Main.qml	Added plugin installer instance and command handlers
viewer/CMakeLists.txt	Disabled PAG_BUILD_TESTS option

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-26T08:53:48Z

viewer/src/rendering/PAGView.cpp

      }
      setProgress(progress);
    }
+  }else {


Missing space after 'else' keyword. Should be } else { following C++ style conventions.

Suggested change

}else {

} else {

Copilot · 2025-09-26T08:53:48Z

viewer/src/platform/mac/PluginInstaller.mm

+
+    if (!QFile::exists(source)) {
+      return false;
+    } else {


Empty else block should be removed as it serves no purpose and reduces code clarity.

Suggested change

} else {

Copilot · 2025-09-26T08:53:49Z

viewer/src/platform/mac/PluginInstaller.mm

+
+  args << "-e" << appleScriptCommand;
+
+  process.start("osascript", args);


Checking exitCode() immediately after start() without waiting for the process to finish. Should call waitForFinished() before checking the exit code.

Suggested change

process.start("osascript", args);

process.start("osascript", args);

process.waitForFinished(300000);

Copilot · 2025-09-26T08:53:49Z

viewer/src/platform/win/PluginInstaller.cpp

+      }
+    }
+  }
+  paths.removeDuplicates();


Using removeDuplicates() after already checking for duplicates with !paths.contains() at line 99-101 is inefficient. Either remove the contains check or the removeDuplicates call.

Copilot · 2025-09-26T08:53:50Z

viewer/src/platform/mac/PluginInstaller.mm

+  char qtResourceCmd[4096] = {0};
+  CopyQtResource(qtResourceCmd, sizeof(qtResourceCmd));


Magic number 4096 is used multiple times for buffer size. Consider defining a named constant for better maintainability.

Copilot · 2025-09-26T08:53:50Z

viewer/src/platform/mac/PluginInstaller.mm

+  char deleteQtResourceCmd[4096] = {0};
+  DeleteQtResource(deleteQtResourceCmd, sizeof(deleteQtResourceCmd));


Magic number 4096 is used multiple times for buffer size. Consider defining a named constant for better maintainability.

Copilot · 2025-09-26T08:53:50Z

viewer/src/platform/mac/PluginInstaller.mm

+
+
+    QString fallbackCommand = command;
+    fallbackCommand.replace("cp -r ", "cp -r ");


This replace operation does nothing as it replaces 'cp -r ' with the same string 'cp -r '. This appears to be dead code that should be removed.

Suggested change

fallbackCommand.replace("cp -r ", "cp -r ");

codecov-commenter · 2025-09-28T02:54:51Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.91%. Comparing base (eb92507) to head (83e5762).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3011      +/-   ##
==========================================
- Coverage   76.95%   76.91%   -0.05%     
==========================================
  Files         413      413              
  Lines       21992    21992              
  Branches     6278     6278              
==========================================
- Hits        16924    16915       -9     
- Misses       3822     3823       +1     
- Partials     1246     1254       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…taller

Hparty · 2025-09-29T03:23:55Z

viewer/src/platform/win/PluginInstaller.cpp

+  }
+}
+
+QString PluginInstaller::getPluginVersionString(const QString& pluginPath) const {


版本判断没处理

Hparty · 2025-09-29T03:32:22Z

viewer/src/platform/win/PluginInstaller.cpp

+  return paths;
+}
+
+QString PluginInstaller::getPluginSourcePath(const QString& pluginName) const {


加一个getPluginFullName用于获取PluginName+后缀，不然后续维护比较麻烦

shlzxjp · 2025-10-20T07:51:15Z

viewer/src/maintenance/PluginInstallerModel.cpp

+          &PluginInstallerModel::uninstallationCompleted);
+}
+
+PluginInstallerModel::~PluginInstallerModel() = default;


没有任何实现的析构函数可以不写

shlzxjp · 2025-10-20T07:52:08Z

viewer/src/maintenance/PluginInstallerModel.cpp

+  return installer->hasUpdate();
+}
+
+InstallResult PluginInstallerModel::installPlugins(bool force) {


应该只有一个插件要安装卸载吧，用单数，去掉s

shlzxjp · 2025-10-20T07:52:32Z

viewer/src/maintenance/PluginInstallerModel.h

+  void uninstallationCompleted(InstallResult result, const QString& message);
+
+ private:
+  std::unique_ptr<PluginInstaller> installer;


初始化下

shlzxjp · 2025-10-20T07:53:32Z

viewer/src/platform/PluginInstaller.cpp

+PluginInstaller::PluginInstaller(QObject* parent) : QObject(parent) {
+}
+
+PluginInstaller::~PluginInstaller() = default;


shlzxjp · 2025-10-20T07:54:46Z

viewer/src/platform/PluginInstaller.cpp

+    return false;
+  }
+
+  int64_t sourceVersion = getPluginVersion(sourcePath);


用auto就可以了

shlzxjp · 2025-10-20T08:58:05Z

viewer/src/platform/mac/PluginInstaller.mm

+QStringList PluginInstaller::getAeInstallPaths() {
+  QStringList paths;
+  int currentYear = QDate::currentDate().year();
+  int startYear = qMax(minSupportedYear, currentYear - 10);


这里为什么需要 -10和+2

这里去匹配一个范围，历史版本与新版本

shlzxjp · 2025-10-20T09:00:31Z

viewer/src/platform/mac/PluginInstaller.mm

+
+  args << "-e" << appleScriptCommand;
+
+  process.start("osascript", args);


看下AI提的这条评论是否合理

这里是合理的，已更改

shlzxjp · 2025-10-20T09:01:51Z

viewer/src/platform/mac/PluginInstaller.mm

+  }
+
+  minSupportedYear = qMax(2010, minYear);
+  maxSupportedYear = qMin(2050, maxYear);


这里的取值和默认最大最小值不一样，统一起来吧

shlzxjp · 2025-10-20T09:04:45Z

viewer/src/platform/win/PluginInstaller.cpp

+  }
+}
+
+QString PluginInstaller::getPluginVersionString(const QString& pluginPath) const {


这个是还没实现吗

漏掉了，已补上

shlzxjp · 2025-10-20T09:07:35Z

viewer/src/platform/mac/PluginInstaller.mm

+
+    QString targetDir = QFileInfo(target).absolutePath();
+    QString mkdirCmd = QString("mkdir -p '%1'").arg(targetDir);
+    QString rmCmd = QString("rm -rf '%1'").arg(target);


这些调用命令行执行相关逻辑的操作，缓存调用C++ API实现更合适一些

…Qt resource management for PAGExporter

YyZz-wy and others added 21 commits July 23, 2025 15:47

Add automatic download and installation for PAGViewer

ea5fe49

codeformat

2a834cf

Update code based on review comments

6929fb0

Update code based on review comments

ce750e2

Resolve comment

1287b4e

fix function name

c87d96d

merge main

44b6157

Add plugin installer functionality and related scripts for managing Q…

49908d3

…t plugins

Add plugin installer functionality and related scripts for managing Q…

02dcaf8

…t plugins

Add plugin installer functionality and related scripts for managing Q…

56cbc37

…t plugins

Add plugin installer functionality and related scripts for managing Q…

c0c5b29

…t plugins

Enhance PluginInstaller to check Windows Registry for Adobe After Eff…

6478202

…ects installation paths and improve path sorting

Refactor PluginInstaller by removing redundant comments and improving…

73cc4bd

… code clarity

Merge remote-tracking branch 'origin/main' into feature/codywwang_ins…

ff29a97

…taller # Conflicts: # viewer/CMakeLists.txt

Add year range configuration and special version detection for Adobe …

678ab29

…After Effects

Add year range configuration and special version detection for Adobe …

785b9e8

…After Effects

Disable test builds and improve version configuration in CMake

193d0fb

Refactor PluginInstaller by removing redundant debug logs and improvi…

4c95acd

…ng command execution flow

Refactor PluginInstaller by removing redundant debug logs and improvi…

96a63b3

…ng command execution flow

Revert commits 96a63b3 and 4c95acd

61c0deb

Refactor PluginInstaller by removing redundant debug logs and improvi…

de811a9

…ng command execution flow

YyZz-wy requested review from Hparty and domchen as code owners September 26, 2025 08:51

Copilot AI review requested due to automatic review settings September 26, 2025 08:51

YyZz-wy requested a review from shlzxjp as a code owner September 26, 2025 08:51

Copilot AI reviewed Sep 26, 2025

View reviewed changes

codeformat

9942c56

YyZz-wy added 2 commits September 28, 2025 11:22

codeformat

27ecda6

Merge remote-tracking branch 'origin/main' into feature/codywwang_ins…

9244c7b

…taller

fix the comment and codeformat

c5576b2

Hparty reviewed Sep 29, 2025

View reviewed changes

YyZz-wy added 8 commits September 30, 2025 17:19

merge main

9064693

codeformat

ec47821

codeformat

f587511

merge main

4d31922

merge main

e6cf642

merge main

f406ee4

merge main

06dc187

merge main

1d73165

shlzxjp changed the title ~~Added exporter install and uninstall function in PAGViewer~~ Added plugin installation and uninstallation functionality to the PAGViewer application, added plugin version management and update checking capabilities. Oct 20, 2025

shlzxjp reviewed Oct 20, 2025

View reviewed changes

YyZz-wy added 6 commits October 22, 2025 17:21

Refactor plugin installation methods for clarity and consistency

a07e479

Add scripts for managing Qt resources in Adobe plugins

c709a8e

merge main

3307583

Enhance Qt resource management in installer scripts and improve logging

3fbe7ea

Implement H264EncoderTools installation with retry logic and enhance …

83ad702

…Qt resource management for PAGExporter

merge main

5097caa

YyZz-wy requested a review from kevingpqi123 as a code owner December 2, 2025 12:07

YyZz-wy added 2 commits December 2, 2025 20:14

codeformat

83e5762

fix error

be44716


		args << "-e" << appleScriptCommand;

		process.start("osascript", args);

	process.start("osascript", args);
	process.start("osascript", args);
	process.waitForFinished(300000);

		char qtResourceCmd[4096] = {0};
		CopyQtResource(qtResourceCmd, sizeof(qtResourceCmd));

		char deleteQtResourceCmd[4096] = {0};
		DeleteQtResource(deleteQtResourceCmd, sizeof(deleteQtResourceCmd));



		QString fallbackCommand = command;
		fallbackCommand.replace("cp -r ", "cp -r ");

Added plugin installation and uninstallation functionality to the PAGViewer application, added plugin version management and update checking capabilities. #3011

Are you sure you want to change the base?

Added plugin installation and uninstallation functionality to the PAGViewer application, added plugin version management and update checking capabilities. #3011

Conversation

YyZz-wy commented Sep 26, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

codecov-commenter commented Sep 28, 2025 •

edited

Loading