Modify S134(apex): Add compliant example and fix non-compliant (#5944)

* Add compliant solution for rule S134 in Apex, fix non-compliant example
- duplicate declaration of j
- illegal shadowing of i
- switch on / when -> if to simplify compliant solution

* Fix spacing, put compliant comments in the right place

* Added missing spaces between ) and {

Author: rombirli

rules/S134/apex/rule.adoc

@@ -12,26 +12,47 @@ The following example demonstrates the behavior of the rule with the default thr
 
 [source,apex]
 ----
-switch on i { // Compliant - depth = 1
-  when 1 {
+if (i == 1) // Compliant - depth = 1
+  /* ... */
+  for (Integer j = 0; j < 10; j++) { // Compliant - depth = 2
     /* ... */
-    for (Integer i = 0, j = 0; i < 10; i++) { // Compliant - depth = 2
+    Integer k = j + 1;
+    if (k == 3) { // Compliant - depth = 3, not exceeding the limit
       /* ... */
-      Integer j = i + 1;
-      if (j == 0){// Compliant - depth = 3, not exceeding the limit
+      while (k < 10) { // Noncompliant - depth = 4
         /* ... */
-        while (j < 10){ // Noncompliant - depth = 4
+        if (k == 1) { // Depth = 5, exceeding the limit, but issues are only reported on depth = 4
           /* ... */
-          if (j == 1){ // Depth = 5, exceeding the limit, but issues are only reported on depth = 4
-            /* ... */
-          }
         }
       }
     }
   }
 }
 ----
 
+==== Compliant solution
+
+[source,apex]
+----
+if (i != 1) {
+  return;
+}
+for (Integer j = 0; j < 10; j++) { // Compliant - depth = 1
+  /* ... */
+  Integer k = j + 1;
+  if (k != 3) {
+    continue;
+  }
+  /* ... */
+  while (k < 10) { // Compliant - depth = 2
+    /* ... */
+    if (k == 1) { // Compliant - depth = 3
+      /* ... */
+    }
+  }
+}
+----
+
 include::../resources.adoc[]
 
 ifdef::env-github,rspecator-view[]