Session flightlist #1407
Open
Session flightlist #1407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Skeletal Model
github-actions
bot
added
the
Area: Application Protocol
github-actions
bot
added
the
Area: Documentation
github-actions
bot
added
the
Area: Translation
sctanf
force-pushed
the
llelievr/session-flightlist
branch
from
f1ce5d3 to
0504b86
Compare
…eVR-Server into llelievr/session-flightlist
loucass003
requested review from
ButterscotchV,
Eirenliel and
Erimelowo
as code owners
…r/session-flightlist
Member
ButterscotchV
left a comment
ButterscotchV
left a comment
There was a problem hiding this comment.
Didn't review the full thing yet, but I wanna give some comments early
| onboarding-automatic_mounting-mounting_reset-step-1 = 2. Press the "Reset Mounting" button and wait for 3 seconds before the trackers' mounting orientations will reset. | ||
| onboarding-automatic_mounting-mounting_reset-step-1 = 2. Press the "Mounting calibration" button and wait for 3 seconds before the trackers' mounting orientations will reset. | ||
| onboarding-automatic_mounting-mounting_reset-feet-step-0 = 1. Stand on your toes, both feets pointing forward. Alternatively you can do it siting on a chair. |
Member
There was a problem hiding this comment.
Suggested change
| onboarding-automatic_mounting-mounting_reset-feet-step-0 = 1. Stand on your toes, both feets pointing forward. Alternatively you can do it siting on a chair. | |
| onboarding-automatic_mounting-mounting_reset-feet-step-0 = 1. Stand on your toes with both feet pointing forward. Alternatively you can do it siting on a chair. |
| tracking_checklist-STEAMVR_DISCONNECTED-desc = SteamVR is not running. Are you using it for vr? | ||
| tracking_checklist-STEAMVR_DISCONNECTED-open = Launch SteamVR | ||
| tracking_checklist-TRACKERS_REST_CALIBRATION = Calibrate your trackers | ||
| tracking_checklist-TRACKERS_REST_CALIBRATION-desc = You didnt perform the tracker calibration. Please let your slimes, highlited in yellow, rest on a static surface for a few secconds |
Member
There was a problem hiding this comment.
Suggested change
| tracking_checklist-TRACKERS_REST_CALIBRATION-desc = You didnt perform the tracker calibration. Please let your slimes, highlited in yellow, rest on a static surface for a few secconds | |
| tracking_checklist-TRACKERS_REST_CALIBRATION-desc = You didn't perform tracker calibration. Please let your Slimes (highlighted in yellow) rest on a stable surface for a few secconds. |
| } | ||
| tracking_checklist-NETWORK_PROFILE_PUBLIC-open = Open Control Panel | ||
| tracking_checklist-STAY_ALIGNED_CONFIGURED = Configure Stay Aligned | ||
| tracking_checklist-STAY_ALIGNED_CONFIGURED-desc = Record the stay aligned poses for an improved imu drift |
Member
There was a problem hiding this comment.
Suggested change
| tracking_checklist-STAY_ALIGNED_CONFIGURED-desc = Record the stay aligned poses for an improved imu drift | |
| tracking_checklist-STAY_ALIGNED_CONFIGURED-desc = Record the Stay Aligned poses for an improved imu drift |
Comment on lines
18
to
26
| field = FastMath.clamp(yawResetTaps.toFloat(), 2f, 10f).toInt() | ||
| field = yawResetTaps | ||
| } | ||
| var fullResetTaps = 3 | ||
| set(fullResetTaps) { | ||
| field = FastMath.clamp(fullResetTaps.toFloat(), 2f, 10f).toInt() | ||
| field = fullResetTaps | ||
| } | ||
| var mountingResetTaps = 3 | ||
| set(mountingResetTaps) { | ||
| field = FastMath.clamp(mountingResetTaps.toFloat(), 2f, 10f).toInt() |
Member
There was a problem hiding this comment.
We can also just use coerceIn for these to not convert to floats and stuff
See: https://kotlinlang.org/api/core/kotlin-stdlib/kotlin.ranges/coerce-in.html
(Might need an import)
Suggested change
| field = FastMath.clamp(yawResetTaps.toFloat(), 2f, 10f).toInt() | |
| field = yawResetTaps | |
| } | |
| var fullResetTaps = 3 | |
| set(fullResetTaps) { | |
| field = FastMath.clamp(fullResetTaps.toFloat(), 2f, 10f).toInt() | |
| field = fullResetTaps | |
| } | |
| var mountingResetTaps = 3 | |
| set(mountingResetTaps) { | |
| field = FastMath.clamp(mountingResetTaps.toFloat(), 2f, 10f).toInt() | |
| field = yawResetTaps.coerceIn(2, 10) | |
| } | |
| var fullResetTaps = 3 | |
| set(fullResetTaps) { | |
| field = fullResetTaps.coerceIn(2, 10) | |
| } | |
| var mountingResetTaps = 3 | |
| set(mountingResetTaps) { | |
| field = mountingResetTaps.coerceIn(2, 10) |
ButterscotchV
requested changes
Nov 24, 2025
Comment on lines
214
to
221
| var legTweaks = LegTweaks(this) | ||
| var tapDetectionManager = TapDetectionManager(this) | ||
| var tapDetectionManager: TapDetectionManager? = null | ||
| var localizer = Localizer(this) | ||
| var ikSolver = IKSolver(headBone) | ||
|
|
||
| // Stay Aligned | ||
| var trackerSkeleton = TrackerSkeleton(this) | ||
| var stayAlignedConfig = StayAlignedConfig() |
Member
There was a problem hiding this comment.
These should all really be val, not var.
| humanPoseManager.server.configManager.vrConfig.resetsConfig.lastMountingMethod = | ||
| MountingMethods.AUTOMATIC | ||
| if (!humanPoseManager.server.trackingChecklistManager.resetMountingCompleted) { | ||
| humanPoseManager.server.trackingChecklistManager.resetMountingCompleted = bodyParts.any { it -> |
Member
There was a problem hiding this comment.
Is any the right choice here? We're essentially just checking if one of the body parts is matching, not all.
Member
Author
There was a problem hiding this comment.
it is a bit broader bc imo its a bigger deal if the status don't clear and get stuck bc of something wierd. bc the list on the sever could mismatch the one in the GUI. I hate the current state of things .... we should have not kept that
Member
There was a problem hiding this comment.
Fair, definitely not ideal. If this is what needs to be done then it can be resolved.
This was referenced Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: SlimeVR/SolarXR-Protocol#178