Ubuntu requirements update to fix rocprofiler-systems build #2318
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add textinfo and bison to README.md for ubuntu build instructions. (fresh ubuntu 24.04.03 install used for testing) Texinfo install fixes a following error: [rocprofiler-systems] WARNING: 'makeinfo' is missing on your system. [rocprofiler-systems] You should only need it if you modified a '.texi' file, or [rocprofiler-systems] any other file indirectly affecting the aspect of the manual. [rocprofiler-systems] You might want to install the Texinfo package: [rocprofiler-systems] <http://www.gnu.org/software/texinfo/> [rocprofiler-systems] The spurious makeinfo call might also be the consequence of [rocprofiler-systems] using a buggy 'make' (AIX, DU, IRIX), in which case you might [rocprofiler-systems] want to install GNU make: [rocprofiler-systems] <http://www.gnu.org/software/make/> [rocprofiler-systems] make[3]: *** [Makefile:1781: doc/bfd.info] Error 127 [rocprofiler-systems] make[3]: Leaving directory '/home/lamikr/own/rock/src/sdk/therock/build/profiler/rocprofiler-systems/build/external/binutils/src/rocprofiler-systems-libiberty-build/bfd' [rocprofiler-systems] make[2]: *** [Makefile:1941: info-recursive] Error 1 [rocprofiler-systems] make[2]: Leaving directory '/home/lamikr/own/rock/src/sdk/therock/build/profiler/rocprofiler-systems/build/external/binutils/src/rocprofiler-systems-libiberty-build/bfd' [rocprofiler-systems] make[1]: *** [Makefile:3114: all-bfd] Error 2 [rocprofiler-systems] make[1]: Leaving directory '/home/lamikr/own/rock/src/sdk/therock/build/profiler/rocprofiler-systems/build/external/binutils/src/rocprofiler-systems-libiberty-build' [rocprofiler-systems] make: *** [Makefile:1028: all] Error 2 [rocprofiler-systems] [8/528] Performing configure step for 'rocprofiler-systems-boost-build' [rocprofiler-systems] Building B2 engine.. Bison install fixes a following error: [rocprofiler-systems] /home/lamikr/own/rock/src/sdk/therock/build/profiler/rocprofiler-systems/build/external/binutils/src/rocprofiler-systems-libiberty-build/missing: 81: bison: not found [rocprofiler-systems] WARNING: 'bison' is missing on your system. [rocprofiler-systems] You should only need it if you modified a '.y' file. [rocprofiler-systems] You may want to install the GNU Bison package: [rocprofiler-systems] <http://www.gnu.org/software/bison/> [rocprofiler-systems] make[2]: *** [Makefile:1244: defparse.c] Error 127 [rocprofiler-systems] make[2]: Leaving directory '/home/lamikr/own/rock/src/sdk/therock/build/profiler/rocprofiler-systems/build/external/binutils/src/rocprofiler-systems-libiberty-build/binutils' [rocprofiler-systems] make[1]: *** [Makefile:4100: all-binutils] Error 2 fixes: #2316 Signed-off-by: Mika Laitio <[email protected]>
Member
|
Tagged @jbonnell-amd , the author of #2132 which added texinfo to our manylinux dockerfile |
jbonnell-amd
approved these changes
Nov 27, 2025
Contributor
jbonnell-amd
left a comment
jbonnell-amd
left a comment
There was a problem hiding this comment.
Looks good, texinfo was added to the manylinux Dockerfile for rocprofiler-systems but bison was already installed there so we didn't need to add that.
Thanks for adding this!
HereThereBeDragons
approved these changes
Nov 27, 2025
dgaliffiAMD
reviewed
Dec 2, 2025
| # Install Ubuntu dependencies | ||
| sudo apt update | ||
| sudo apt install gfortran git ninja-build cmake g++ pkg-config xxd patchelf automake libtool python3-venv python3-dev libegl1-mesa-dev | ||
| sudo apt install gfortran git ninja-build cmake g++ pkg-config xxd patchelf automake libtool python3-venv python3-dev libegl1-mesa-dev texinfo bison |
Contributor
There was a problem hiding this comment.
Suggested change
| sudo apt install gfortran git ninja-build cmake g++ pkg-config xxd patchelf automake libtool python3-venv python3-dev libegl1-mesa-dev texinfo bison | |
| sudo apt install gfortran git ninja-build cmake g++ pkg-config xxd patchelf automake libtool python3-venv python3-dev libegl1-mesa-dev texinfo bison flex |
Can we add flex too.
See #2364.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add textinfo and bison to README.md for ubuntu build instructions. (fresh ubuntu 24.04.03 install used for testing)
Texinfo install fixes a following error:
Bison install fixes a following error:
fixes: #2316