Skip to content

Conversation

@gchinora
Copy link
Contributor

The whole purpose of the op-builders is to factor out the main functionalities behind the current onnx parsers and put them in a separate set of files (under the folder ./src/op/builder/ ) so they could be reused in different parts of the application. That is this is mainly a refactoring task; the passing of the already existing unit and verify tests should be the proof that the refactoring left the integrity of mgr intact.

related issue: migraphx-benchmark#203
covered parsers in this PR:

  • QuantizeLinear
  • DequantizeLinear

@gchinora gchinora requested a review from causten as a code owner November 26, 2025 13:05
@gchinora gchinora marked this pull request as draft November 26, 2025 13:05
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4470      +/-   ##
===========================================
+ Coverage    92.21%   92.22%   +0.01%     
===========================================
  Files          561      563       +2     
  Lines        27228    27233       +5     
===========================================
+ Hits         25107    25113       +6     
+ Misses        2121     2120       -1     
Files with missing lines Coverage Δ
src/onnx/parse_dequantizelinear.cpp 100.00% <100.00%> (ø)
src/onnx/quantize_dequantize_linear.cpp 100.00% <100.00%> (ø)
src/op/builder/dequantizelinear.cpp 100.00% <100.00%> (ø)
...migraphx/op/builder/quantize_dequantize_linear.hpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants