Skip to content

Commit b46a9c1

Browse files
Merge pull request #115 from jolelievre/reskin
Adapt selectors for new branding
2 parents 5e536f9 + 3b235c8 commit b46a9c1

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

Makefile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ help: ## Display this help menu
44
check:
55
npm run build
66

7-
test: ## Build and copy to the dependencies directory for the project
8-
rm dist -rf
7+
test: ## Build and copy to the dependencies directory for the project
8+
rm -rf dist
99
npm run build
10-
rm $(filter-out $@,$(MAKECMDGOALS))/tests/UI/node_modules/@prestashop-core/ui-testing/dist/ -r
11-
cp dist $(filter-out $@,$(MAKECMDGOALS))/tests/UI/node_modules/@prestashop-core/ui-testing/ -r
10+
rm -r $(filter-out $@,$(MAKECMDGOALS))/tests/UI/node_modules/@prestashop-core/ui-testing/dist/
11+
cp -r dist $(filter-out $@,$(MAKECMDGOALS))/tests/UI/node_modules/@prestashop-core/ui-testing/
1212
cp package.json $(filter-out $@,$(MAKECMDGOALS))/tests/UI/node_modules/@prestashop-core/ui-testing/
1313

14-
.DEFAULT_GOAL := help
14+
.DEFAULT_GOAL := help

src/pages/BO/BOBasePage.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@ export default class BOBasePage extends CommonPage implements BOBasePagePageInte
6161

6262
protected readonly helpButton: string;
6363

64+
protected readonly closeHelpButton: string;
65+
6466
private readonly menuMobileButton: string;
6567

6668
private readonly notificationsLink: string;
@@ -323,6 +325,7 @@ export default class BOBasePage extends CommonPage implements BOBasePagePageInte
323325

324326
// Header links
325327
this.helpButton = '#product_form_open_help';
328+
this.closeHelpButton = '#right-sidebar #ps-quicknav-sidebar .quicknav-header [data-target=".sidebar"]';
326329
this.menuMobileButton = '.js-mobile-menu';
327330
this.notificationsLink = '#notification,#notif';
328331
this.notificationsDropDownMenu = '#notification div.dropdown-menu-right.notifs_dropdown,#notif div.dropdown-menu';
@@ -1052,7 +1055,7 @@ export default class BOBasePage extends CommonPage implements BOBasePagePageInte
10521055
* @returns {Promise<boolean>}
10531056
*/
10541057
async closeHelpSideBar(page: Page): Promise<boolean> {
1055-
await this.waitForSelectorAndClick(page, this.helpButton);
1058+
await this.waitForSelectorAndClick(page, this.closeHelpButton);
10561059
return this.elementVisible(page, `${this.rightSidebar}:not(.sidebar-open)`, 2000);
10571060
}
10581061

src/versions/develop/pages/BO/login/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ class LoginPage extends BOBasePage implements LoginPageInterface {
5959

6060
this.loginBackShopLink = '#login-panel span.login-back-shop';
6161
this.loginFooter = '#login-footer';
62-
this.allRightsReservedLink = `${this.loginFooter} p.text-center.text-muted a`;
62+
this.allRightsReservedLink = `${this.loginFooter} .text-muted a`;
6363
this.twitterLink = `${this.loginFooter} a.link-social.link-twitter`;
6464
this.facebookLink = `${this.loginFooter} a.link-social.link-facebook`;
6565
this.githubLink = `${this.loginFooter} a.link-social.link-github`;

0 commit comments

Comments
 (0)