r.curvenumber: replace python implementation with C version #1550
+719
−611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@petrasovaa could you please take a look? |
petrasovaa
approved these changes
Dec 1, 2025
Contributor
petrasovaa
left a comment
petrasovaa
left a comment
There was a problem hiding this comment.
Great improvement, the tests pass so this is good to go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the r.curvenumber addon from Python to C to improve performance.
During a project, the current Python version was used on a nominal sized region (nrows = 47104, ncols = 36785) and
/usr/bin/timereported that wall-clock time was 1h33m52s, whereas this C implementation took 1m37.69s (a speedup of ~57.6x).The module interface and outputs are unchanged; only the implementation has been ported to C.