Fix TypeScript compilation errors in LOD branch #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LOD branch had 16 TypeScript compilation errors preventing builds, primarily from type incompatibilities with THREE.js, missing type definitions, and unsafe DOM event handling.
Type Compatibility Fixes
Uint8Array buffer types: THREE.js DataTexture/Data3DTexture constructors expect
ArrayBuffer, but zarr returnsArrayBufferLike. Created new instances to ensure type compatibility:PersistenceMode type: Defined locally as
'r' | 'r+' | 'a' | 'w' | 'w-'instead of importing from non-exported zarr internal types.Event Handling Type Safety
Added helper functions to avoid inline type assertions in Svelte templates:
Modal dialogs: Replaced
'showModal' in modalchecks withmodal instanceof HTMLDialogElementfor proper type narrowing.Shader Import Updates
Updated example files to import
volumeTransfer.fraginstead of removedvolume.frag.Function Signature Fixes
Made
getVoxelAndVolumeSizeparameters optional with defaults to match call sites that only provide{ store, shape }.Original prompt
Created from VS Code via the GitHub Pull Request extension.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.