Clean up analyzer suggestions

MattKotsenas · MattKotsenas · commit 3ceda69db3e5 · 2024-07-31T18:08:24.000-07:00
diff --git a/src/Common/SarifParser.cs b/src/Common/SarifParser.cs
@@ -98,11 +98,11 @@ private IEnumerable<DiagnosticConfig> ParseRun(Run run)
             yield return new DiagnosticConfig(
                 id: rule.Id,
                 title: rule.GetTitle(version),
-                category: rule.GetPropertyOrDefault("category", string.Empty),
+                category: rule.GetPropertyOrDefault("category", defaultValue: string.Empty),
                 defaultSeverity: defaultSeverity,
                 isEnabledByDefault: defaultConfiguration.Enabled,
                 effectiveSeverities: effectiveSeverities,
-                isEverSuppressed: rule.GetPropertyOrDefault("isEverSuppressed", false));
+                isEverSuppressed: rule.GetPropertyOrDefault("isEverSuppressed", defaultValue: false));
         }
     }
 }
diff --git a/src/Tool/CommandFilterFactory.cs b/src/Tool/CommandFilterFactory.cs
@@ -3,7 +3,7 @@
 
 namespace SquiggleCop.Tool;
 
-internal class CommandFilterFactory<TCommandFilterAttribute> : IFilterFactory where TCommandFilterAttribute : ICommandFilter
+internal sealed class CommandFilterFactory<TCommandFilterAttribute> : IFilterFactory where TCommandFilterAttribute : ICommandFilter
 {
     public IFilterMetadata CreateInstance(IServiceProvider serviceProvider)
     {
diff --git a/src/Tool/DotnetToolApplicationMetadataProvider.cs b/src/Tool/DotnetToolApplicationMetadataProvider.cs
@@ -4,7 +4,7 @@
 
 namespace SquiggleCop.Tool;
 
-internal class DotnetToolApplicationMetadataProvider : ICoconaApplicationMetadataProvider
+internal sealed class DotnetToolApplicationMetadataProvider : ICoconaApplicationMetadataProvider
 {
     public string GetDescription()
     {
diff --git a/src/Tool/SpectreErrorHandlerFilterAttribute.cs b/src/Tool/SpectreErrorHandlerFilterAttribute.cs
@@ -3,7 +3,7 @@
 
 namespace SquiggleCop.Tool;
 
-internal class SpectreErrorHandlerFilterAttribute : CommandFilterAttribute
+internal sealed class SpectreErrorHandlerFilterAttribute : CommandFilterAttribute
 {
     private readonly IAnsiConsole _console;
 
diff --git a/src/Tool/SpectreParameterBindExceptionFilterAttribute.cs b/src/Tool/SpectreParameterBindExceptionFilterAttribute.cs
@@ -6,7 +6,7 @@
 
 namespace SquiggleCop.Tool;
 
-internal class SpectreParameterBindExceptionFilterAttribute : CommandFilterAttribute
+internal sealed class SpectreParameterBindExceptionFilterAttribute : CommandFilterAttribute
 {
     private readonly IAnsiConsole _console;
 

Original file line number	Diff line number	Diff line change
`@@ -98,11 +98,11 @@ private IEnumerable<DiagnosticConfig> ParseRun(Run run)`
`98`	`98`	`yield return new DiagnosticConfig(`
`99`	`99`	`id: rule.Id,`
`100`	`100`	`title: rule.GetTitle(version),`
`101`		`- category: rule.GetPropertyOrDefault("category", string.Empty),`
	`101`	`+ category: rule.GetPropertyOrDefault("category", defaultValue: string.Empty),`
`102`	`102`	`defaultSeverity: defaultSeverity,`
`103`	`103`	`isEnabledByDefault: defaultConfiguration.Enabled,`
`104`	`104`	`effectiveSeverities: effectiveSeverities,`
`105`		`- isEverSuppressed: rule.GetPropertyOrDefault("isEverSuppressed", false));`
	`105`	`+ isEverSuppressed: rule.GetPropertyOrDefault("isEverSuppressed", defaultValue: false));`
`106`	`106`	`}`
`107`	`107`	`}`
`108`	`108`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`
`4`	`4`	`namespace SquiggleCop.Tool;`
`5`	`5`
`6`		`-internal class CommandFilterFactory<TCommandFilterAttribute> : IFilterFactory where TCommandFilterAttribute : ICommandFilter`
	`6`	`+internal sealed class CommandFilterFactory<TCommandFilterAttribute> : IFilterFactory where TCommandFilterAttribute : ICommandFilter`
`7`	`7`	`{`
`8`	`8`	`public IFilterMetadata CreateInstance(IServiceProvider serviceProvider)`
`9`	`9`	`{`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`
`5`	`5`	`namespace SquiggleCop.Tool;`
`6`	`6`
`7`		`-internal class DotnetToolApplicationMetadataProvider : ICoconaApplicationMetadataProvider`
	`7`	`+internal sealed class DotnetToolApplicationMetadataProvider : ICoconaApplicationMetadataProvider`
`8`	`8`	`{`
`9`	`9`	`public string GetDescription()`
`10`	`10`	`{`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`
`4`	`4`	`namespace SquiggleCop.Tool;`
`5`	`5`
`6`		`-internal class SpectreErrorHandlerFilterAttribute : CommandFilterAttribute`
	`6`	`+internal sealed class SpectreErrorHandlerFilterAttribute : CommandFilterAttribute`
`7`	`7`	`{`
`8`	`8`	`private readonly IAnsiConsole _console;`
`9`	`9`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`
`7`	`7`	`namespace SquiggleCop.Tool;`
`8`	`8`
`9`		`-internal class SpectreParameterBindExceptionFilterAttribute : CommandFilterAttribute`
	`9`	`+internal sealed class SpectreParameterBindExceptionFilterAttribute : CommandFilterAttribute`
`10`	`10`	`{`
`11`	`11`	`private readonly IAnsiConsole _console;`
`12`	`12`