add security workflow for main #9085
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
.github/workflows/security.yml
Outdated
| name: Security | ||
| jobs: | ||
| security: | ||
| uses: KittyCAD/gha-workflows/.github/workflows/security.yml@security |
Contributor
There was a problem hiding this comment.
Using a mutable branch reference (@security) for a reusable workflow is a security vulnerability. If the security branch in KittyCAD/gha-workflows is compromised or modified, malicious code will execute with access to all repository secrets (secrets: inherit on line 13).
Impact: Supply chain attack vector that could lead to:
- Unauthorized access to all repository secrets
- Arbitrary code execution in the CI environment
- Potential credential theft or repository compromise
Fix: Pin to an immutable reference:
uses: KittyCAD/gha-workflows/.github/workflows/security.yml@<commit-sha>
# or use a version tag
uses: KittyCAD/gha-workflows/.github/workflows/[email protected]
Suggested change
| uses: KittyCAD/gha-workflows/.github/workflows/security.yml@security | |
| uses: KittyCAD/gha-workflows/.github/workflows/security.yml@v1.0.0 |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will invoke a bunch of analysis tools. Right now it only collects the SBOM