-
-
Notifications
You must be signed in to change notification settings - Fork 198
wip: add a create_distribution entry point
#1073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
this creates basically a new julia "distribution" with a custom set of packages in it. Right now: - packages get added to the sysimage - packages are treated as stdlib so they can be loaded via `using Package` without a corresponding project file - packages are also treated as stdlibs by Pkg - packages source code is not copied, shims are added so that Pkg will properly treat it as an stdlib
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1073 +/- ##
==========================================
- Coverage 86.21% 79.86% -6.35%
==========================================
Files 3 3
Lines 805 869 +64
==========================================
Hits 694 694
- Misses 111 175 +64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| - `copy_globs::Vector{String}=String[]`: Glob patterns for copying package files to the stdlib directory. | ||
| Patterns are relative to each package root and apply to all packages in the distribution. | ||
| Example: `["assets/**", "data/**"]` copies assets and data directories for all packages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When specifying globs, if one forgets to include "src/**", you end up with a distribution that does not work because none of the packages can be loaded. I'm not 100% sure if this is true in general, but in my testing when I messed this up nothing would work.
I'm wondering if making the stub generation conditional on whether the src folder was copied over. That way there is no extra configuration to be done, although I guess there could be an argument to explicitly disable it, and when someone forgets to add "src/**" to the globs the distribution still ends up working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the stub generation is even conditional on whether the package entrypoint is already in the target location or not.
This creates basically a new julia "distribution" with a custom set of packages in it.
Right now:
using Packagewithout a corresponding project fileTODO: