fix: BROS-651: Fix Vector undo when completing the region. #8916
+25
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8916 +/- ##
===========================================
- Coverage 66.04% 57.78% -8.27%
===========================================
Files 828 561 -267
Lines 64832 40893 -23939
Branches 11044 11043 -1
===========================================
- Hits 42820 23630 -19190
+ Misses 22008 17259 -4749
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hlomzik
approved these changes
Dec 1, 2025
Member
Author
|
/git merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where undo hotkey won't do anything during drawing and/or after competing a region. This is done by removing the
isDrawingcheck in the undo hotkey handler. This behavior matches the behavior of the undo/redo buttons in the sidebar.Another issue this PR addresses is incorrect marking of the incomplete regions in the sidebar -- previously the code wouldn't account for
maxPointsproperty correctly.