WIP: Adding placeholder for using osascript to register/unregister login items

Author: vraravam

Library/Homebrew/cask/installer.rb

@@ -317,13 +317,14 @@ def install_artifacts(predecessor: nil)
         already_installed_artifacts.unshift(artifact)
       end
 
-      # TODO: should we register the login_items here?
-      # if login_items?
-      #   login_items.each do |lgi|
-      #     # TODO: register the login_items here using osascript
-      #     puts "***** WILL REGISTER login_item: #{lgi}"
-      #   end
-      # end
+      if login_items?
+        @cask.login_items.each do |lgi|
+          # TODO: register the login_items here using osascript
+          ohai "***** Will REGISTER login_item: #{lgi}"
+        end
+      else
+        ohai "Skipping processing of login_items"
+      end
 
       save_config_file
       save_download_sha if @cask.version.latest?
@@ -561,6 +562,15 @@ def uninstall_artifacts(clear: false, successor: nil)
       odebug "Uninstalling artifacts"
       odebug "#{::Utils.pluralize("artifact", artifacts.length, include_count: true)} defined", artifacts
 
+      if login_items?
+        @cask.login_items.each do |lgi|
+          # TODO: unregister the login_items here using osascript
+          ohai "***** Will UNREGISTER login_item: #{lgi}"
+        end
+      else
+        ohai "Skipping processing of login_items"
+      end
+
       artifacts.each do |artifact|
         if artifact.respond_to?(:uninstall_phase)
           odebug "Uninstalling artifact of class #{artifact.class}"

Library/Homebrew/cask/reinstall.rb

@@ -18,7 +18,7 @@ def self.reinstall_casks(
       require_sha: false,
       quarantine: false,
       zap: false,
-      login_items: false
+      login_items: true
     )
       require "cask/installer"
 

Library/Homebrew/cmd/uninstall.rb

@@ -67,7 +67,7 @@ def run
 
             raise Cask::CaskNotInstalledError, cask if !cask.installed? && !args.force?
 
-            Cask::Installer.new(cask, verbose: args.verbose?, force: args.force?).zap
+            Cask::Installer.new(cask, verbose: args.verbose?, force: args.force?, login_items: true).zap
           end
         else
           Cask::Uninstall.uninstall_casks(

Library/Homebrew/test/cask/reinstall_spec.rb

@@ -13,6 +13,7 @@
       ==> Downloading file:.*caffeine.zip
       Already downloaded: .*--caffeine.zip
       ==> Uninstalling Cask local-caffeine
+      ==> Skipping processing of login_items
       ==> Backing App 'Caffeine.app' up to '.*Caffeine.app'
       ==> Removing App '.*Caffeine.app'
       ==> Purging files for version 1.2.3 of Cask local-caffeine
@@ -35,6 +36,7 @@
       ==> Downloading file:.*caffeine.zip
       Already downloaded: .*--caffeine.zip
       ==> Implied `brew uninstall --cask local-caffeine`
+      ==> Skipping processing of login_items
       ==> Backing App 'Caffeine.app' up to '.*Caffeine.app'
       ==> Removing App '.*Caffeine.app'
       ==> Dispatching zap stanza

Library/Homebrew/test/cask/uninstall_spec.rb

@@ -10,6 +10,7 @@
 
     output = Regexp.new <<~EOS
       ==> Uninstalling Cask local-caffeine
+      ==> Skipping processing of login_items
       ==> Backing App 'Caffeine.app' up to '.*Caffeine.app'
       ==> Removing App '.*Caffeine.app'
       ==> Purging files for version 1.2.3 of Cask local-caffeine