Merge pull request #20969 from Homebrew/dug-target-ruby-version

Bump rubocop TargetRubyVersion

Author: MikeMcQuaid

Library/.rubocop.yml

@@ -18,10 +18,7 @@ inherit_mode:
     - Exclude
 
 AllCops:
-  # TODO: This is the default parser in Ruby >= 3.4
-  # https://github.com/rubocop/rubocop-ast/blob/6b9136235219e9448ee4f369e17cf69bcd9db621/lib/rubocop/ast/processed_source.rb#L385
-  ParserEngine: parser_prism
-  TargetRubyVersion: 3.3
+  TargetRubyVersion: 3.4
   NewCops: enable
   Include:
     - "**/*.rbi"
@@ -412,6 +409,10 @@ Style/InvertibleUnlessCondition:
     :zero?:
     :blank?: :present?
 
+# Reconsider once sorbet supports "it": https://github.com/sorbet/sorbet/issues/8375
+Style/ItBlockParameter:
+  Enabled: false
+
 Style/MutableConstant:
   # would rather freeze too much than too little
   EnforcedStyle: strict

Library/Homebrew/test/rubocop_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "open3"
+require "yaml"
 
 RSpec.describe "RuboCop" do
   context "when calling `rubocop` outside of the Homebrew environment" do
@@ -23,4 +24,17 @@
       expect(status).to be_a_success
     end
   end
+
+  context "with TargetRubyVersion" do
+    it "matches .ruby-version" do
+      rubocop_config_path = HOMEBREW_LIBRARY_PATH.parent/".rubocop.yml"
+      rubocop_config = YAML.unsafe_load_file(rubocop_config_path)
+      target_ruby_version = rubocop_config.dig("AllCops", "TargetRubyVersion")
+
+      ruby_version_path = HOMEBREW_LIBRARY_PATH/".ruby-version"
+      ruby_version = ruby_version_path.read.strip.to_f
+
+      expect(target_ruby_version).to eq(ruby_version)
+    end
+  end
 end